Skip to content

Commit 50f16f0

Browse files
Merge branch '3.4' into 4.3
* 3.4: cs fix Replace calls to setExpectedException by Pollyfill
2 parents a09b105 + 2044bea commit 50f16f0

File tree

2 files changed

+8
-17
lines changed

2 files changed

+8
-17
lines changed

Tests/Command/CachePoolDeleteCommandTest.php

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -76,11 +76,7 @@ public function testCommandDeleteFailed()
7676
->with('bar')
7777
->willReturn(false);
7878

79-
if (method_exists($this, 'expectExceptionMessage')) {
80-
$this->expectExceptionMessage('Cache item "bar" could not be deleted.');
81-
} else {
82-
$this->setExpectedException('Exception', 'Cache item "bar" could not be deleted.');
83-
}
79+
$this->expectExceptionMessage('Cache item "bar" could not be deleted.');
8480

8581
$tester = $this->getCommandTester($this->getKernel());
8682
$tester->execute(['pool' => 'foo', 'key' => 'bar']);

Tests/DependencyInjection/ConfigurationTest.php

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
use Doctrine\DBAL\Connection;
1515
use PHPUnit\Framework\TestCase;
16+
use Symfony\Bridge\PhpUnit\ForwardCompatTestTrait;
1617
use Symfony\Bundle\FrameworkBundle\DependencyInjection\Configuration;
1718
use Symfony\Bundle\FullStack;
1819
use Symfony\Component\Config\Definition\Exception\InvalidConfigurationException;
@@ -24,6 +25,8 @@
2425

2526
class ConfigurationTest extends TestCase
2627
{
28+
use ForwardCompatTestTrait;
29+
2730
public function testDefaultConfig()
2831
{
2932
$processor = new Processor();
@@ -140,12 +143,8 @@ public function provideValidAssetsPackageNameConfigurationTests()
140143
*/
141144
public function testInvalidAssetsConfiguration(array $assetConfig, $expectedMessage)
142145
{
143-
if (method_exists($this, 'expectException')) {
144-
$this->expectException(InvalidConfigurationException::class);
145-
$this->expectExceptionMessage($expectedMessage);
146-
} else {
147-
$this->setExpectedException(InvalidConfigurationException::class, $expectedMessage);
148-
}
146+
$this->expectException(InvalidConfigurationException::class);
147+
$this->expectExceptionMessage($expectedMessage);
149148

150149
$processor = new Processor();
151150
$configuration = new Configuration(true);
@@ -194,12 +193,8 @@ public function provideInvalidAssetConfigurationTests()
194193
public function testItShowANiceMessageIfTwoMessengerBusesAreConfiguredButNoDefaultBus()
195194
{
196195
$expectedMessage = 'You must specify the "default_bus" if you define more than one bus.';
197-
if (method_exists($this, 'expectException')) {
198-
$this->expectException(InvalidConfigurationException::class);
199-
$this->expectExceptionMessage($expectedMessage);
200-
} else {
201-
$this->setExpectedException(InvalidConfigurationException::class, $expectedMessage);
202-
}
196+
$this->expectException(InvalidConfigurationException::class);
197+
$this->expectExceptionMessage($expectedMessage);
203198
$processor = new Processor();
204199
$configuration = new Configuration(true);
205200

0 commit comments

Comments
 (0)