feature #52024 [AssetMapper] Add a "package specifier" to importmap in case import name != package+path (weaverryan)

This PR was squashed before being merged into the 6.4 branch.

Discussion
----------

[AssetMapper] Add a "package specifier" to importmap in case import name != package+path

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | yes
| New feature?  | yes
| Deprecations? | no
| Tickets       | None
| License       | MIT

Hi!

Sorry for the large PR - this tightens up the component after the many recent enhancements.

`tl;dr` Makes "vendor" importmap entries work identically to "local" entries when it comes to preloading (a bug). Also tightens up `ImportMapEntry`, which is a tricky class because if an entry is "remote", it has 2 extra, required, properties.

Full changes:

* Make ImportMapEntry stricter so that, when remote, version & packageModuleSpecifier are always set.
* Set the "path" property always for ImportMapEntry, making them no different than local files through most of the system.
* Related, fix a bug where if a vendor .js file imported another module, that other module was not previously preloaded when the vendor module was preloaded.
* Fix a bug with downloaded package paths if you include a specific package - chart.js - and also a path - chart.js/auto. Previously, this would try to create both a file and directory called chart.js,
* Fix bug where imports weren't matching if some spaces were missing

Cheers!

Commits
-------

c80a1abf8b4 [AssetMapper] Add a "package specifier" to importmap in case import name != package+path

Author: fabpot

DependencyInjection/FrameworkExtension.php

@@ -1363,8 +1363,8 @@ private function registerAssetMapperConfiguration(array $config, ContainerBuilde
             ->setArgument(1, $config['missing_import_mode']);
 
         $container
-            ->getDefinition('asset_mapper.importmap.remote_package_downloader')
-            ->replaceArgument(2, $config['vendor_dir'])
+            ->getDefinition('asset_mapper.importmap.remote_package_storage')
+            ->replaceArgument(0, $config['vendor_dir'])
         ;
         $container
             ->getDefinition('asset_mapper.mapped_asset_factory')

Resources/config/asset_mapper.php

@@ -35,6 +35,7 @@
 use Symfony\Component\AssetMapper\ImportMap\ImportMapRenderer;
 use Symfony\Component\AssetMapper\ImportMap\ImportMapUpdateChecker;
 use Symfony\Component\AssetMapper\ImportMap\RemotePackageDownloader;
+use Symfony\Component\AssetMapper\ImportMap\RemotePackageStorage;
 use Symfony\Component\AssetMapper\ImportMap\Resolver\JsDelivrEsmResolver;
 use Symfony\Component\AssetMapper\MapperAwareAssetPackage;
 use Symfony\Component\AssetMapper\Path\PublicAssetsPathResolver;
@@ -145,6 +146,7 @@
         ->set('asset_mapper.importmap.config_reader', ImportMapConfigReader::class)
             ->args([
                 abstract_arg('importmap.php path'),
+                service('asset_mapper.importmap.remote_package_storage'),
             ])
 
         ->set('asset_mapper.importmap.manager', ImportMapManager::class)
@@ -157,11 +159,16 @@
             ])
         ->alias(ImportMapManager::class, 'asset_mapper.importmap.manager')
 
+        ->set('asset_mapper.importmap.remote_package_storage', RemotePackageStorage::class)
+            ->args([
+                abstract_arg('vendor directory'),
+            ])
+
         ->set('asset_mapper.importmap.remote_package_downloader', RemotePackageDownloader::class)
             ->args([
+                service('asset_mapper.importmap.remote_package_storage'),
                 service('asset_mapper.importmap.config_reader'),
                 service('asset_mapper.importmap.resolver'),
-                abstract_arg('vendor directory'),
             ])
 
         ->set('asset_mapper.importmap.resolver', JsDelivrEsmResolver::class)