do not re-register commands each time a Console\Application is run

tomdmaguire · fabpot · commit 59151285959e · 2013-06-13T09:04:38.000+02:00
diff --git a/Console/Application.php b/Console/Application.php
@@ -27,6 +27,7 @@
 class Application extends BaseApplication
 {
     private $kernel;
+    private $commandsRegistered = false;
 
     /**
      * Constructor.
@@ -65,7 +66,9 @@ public function getKernel()
      */
     public function doRun(InputInterface $input, OutputInterface $output)
     {
-        $this->registerCommands();
+        if (!$this->commandsRegistered) {
+            $this->registerCommands();
+        }
 
         if (true === $input->hasParameterOption(array('--shell', '-s'))) {
             $shell = new Shell($this);
@@ -87,5 +90,7 @@ protected function registerCommands()
                 $bundle->registerCommands($this);
             }
         }
+
+        $this->commandsRegistered = true;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,7 @@`
`27`	`27`	`class Application extends BaseApplication`
`28`	`28`	`{`
`29`	`29`	`private $kernel;`
	`30`	`+ private $commandsRegistered = false;`
`30`	`31`
`31`	`32`	`/**`
`32`	`33`	`* Constructor.`
`@@ -65,7 +66,9 @@ public function getKernel()`
`65`	`66`	`*/`
`66`	`67`	`public function doRun(InputInterface $input, OutputInterface $output)`
`67`	`68`	`{`
`68`		`- $this->registerCommands();`
	`69`	`+ if (!$this->commandsRegistered) {`
	`70`	`+ $this->registerCommands();`
	`71`	`+ }`
`69`	`72`
`70`	`73`	`if (true === $input->hasParameterOption(array('--shell', '-s'))) {`
`71`	`74`	`$shell = new Shell($this);`
`@@ -87,5 +90,7 @@ protected function registerCommands()`
`87`	`90`	`$bundle->registerCommands($this);`
`88`	`91`	`}`
`89`	`92`	`}`
	`93`	`+`
	`94`	`+ $this->commandsRegistered = true;`
`90`	`95`	`}`
`91`	`96`	`}`