merged branch lsmith77/template_locator (PR #2128)

Commits
-------

afc0971 make it easier to customize the cache lookup in the TemplateLocator

Discussion
----------

make it easier to customize the cache lookup in the TemplateLocator

---------------------------------------------------------------------------

by fabpot at 2011/09/22 01:21:56 -0700

Do you any use case for that?

---------------------------------------------------------------------------

by lsmith77 at 2011/09/22 01:27:06 -0700

Yes in the ThemeBundle we override the default cache to include the key + theme:
https://github.com/liip/liipthemebundle/pull/9/files#L7R53

---------------------------------------------------------------------------

by lsmith77 at 2011/09/22 01:29:18 -0700

though i just thought about it .. if we do not put this into 2.0, it might not be worth the trouble.

---------------------------------------------------------------------------

by pjedrzejewski at 2011/09/22 02:19:42 -0700

+1 for this.

Author: fabpot

Templating/Loader/TemplateLocator.php

@@ -40,6 +40,18 @@ public function __construct(FileLocatorInterface $locator, $cacheDir = null)
         $this->locator = $locator;
     }
 
+    /**
+     * Returns a full path for a given file.
+     *
+     * @param TemplateReferenceInterface $template     A template
+     *
+     * @return string The full path for the file
+     */
+    protected function getCacheKey($template)
+    {
+        return $template->getLogicalName();
+    }
+
     /**
      * Returns a full path for a given file.
      *
@@ -58,7 +70,7 @@ public function locate($template, $currentPath = null, $first = true)
             throw new \InvalidArgumentException("The template must be an instance of TemplateReferenceInterface.");
         }
 
-        $key = $template->getLogicalName();
+        $key = $this->getCacheKey($template);
 
         if (isset($this->cache[$key])) {
             return $this->cache[$key];