Skip to content

Commit 78f27b0

Browse files
committed
minor #22039 Skip abstract definitions in compiler passes (chalasr)
This PR was merged into the 3.3-dev branch. Discussion ---------- Skip abstract definitions in compiler passes | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21761 | License | MIT | Doc PR | n/a Commits ------- fc1ba0d64a Skip abstract definitions in compiler passes
2 parents e6c1a45 + 32dee2a commit 78f27b0

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

Tests/DependencyInjection/Compiler/AddConsoleCommandPassTest.php

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,10 +62,6 @@ public function visibilityProvider()
6262
);
6363
}
6464

65-
/**
66-
* @expectedException \InvalidArgumentException
67-
* @expectedExceptionMessage The service "my-command" tagged "console.command" must not be abstract.
68-
*/
6965
public function testProcessThrowAnExceptionIfTheServiceIsAbstract()
7066
{
7167
$container = new ContainerBuilder();
@@ -77,6 +73,8 @@ public function testProcessThrowAnExceptionIfTheServiceIsAbstract()
7773
$container->setDefinition('my-command', $definition);
7874

7975
$container->compile();
76+
77+
$this->assertSame(array(), $container->getParameter('console.command.ids'));
8078
}
8179

8280
/**

0 commit comments

Comments
 (0)