do not mock the container builder in tests

xabbuh · xabbuh · commit 93a30787081d · 2018-02-14T11:03:57.000+01:00
diff --git a/Tests/DependencyInjection/Compiler/CachePoolPrunerPassTest.php b/Tests/DependencyInjection/Compiler/CachePoolPrunerPassTest.php
@@ -44,27 +44,17 @@ public function testCompilerPassReplacesCommandArgument()
 
     public function testCompilePassIsIgnoredIfCommandDoesNotExist()
     {
-        $container = $this
-            ->getMockBuilder(ContainerBuilder::class)
-            ->setMethods(array('hasDefinition', 'getDefinition', 'findTaggedServiceIds'))
-            ->getMock();
-
-        $container
-            ->expects($this->atLeastOnce())
-            ->method('hasDefinition')
-            ->with(CachePoolPruneCommand::class)
-            ->will($this->returnValue(false));
-
-        $container
-            ->expects($this->never())
-            ->method('getDefinition');
+        $container = new ContainerBuilder();
 
-        $container
-            ->expects($this->never())
-            ->method('findTaggedServiceIds');
+        $definitionsBefore = count($container->getDefinitions());
+        $aliasesBefore = count($container->getAliases());
 
         $pass = new CachePoolPrunerPass();
         $pass->process($container);
+
+        // the container is untouched (i.e. no new definitions or aliases)
+        $this->assertCount($definitionsBefore, $container->getDefinitions());
+        $this->assertCount($aliasesBefore, $container->getAliases());
     }
 
     /**
diff --git a/Tests/DependencyInjection/Compiler/ConfigCachePassTest.php b/Tests/DependencyInjection/Compiler/ConfigCachePassTest.php
@@ -44,13 +44,16 @@ public function testThatCheckersAreProcessedInPriorityOrder()
 
     public function testThatCheckersCanBeMissing()
     {
-        $container = $this->getMockBuilder('Symfony\Component\DependencyInjection\ContainerBuilder')->setMethods(array('findTaggedServiceIds'))->getMock();
+        $container = new ContainerBuilder();
 
-        $container->expects($this->atLeastOnce())
-            ->method('findTaggedServiceIds')
-            ->will($this->returnValue(array()));
+        $definitionsBefore = count($container->getDefinitions());
+        $aliasesBefore = count($container->getAliases());
 
         $pass = new ConfigCachePass();
         $pass->process($container);
+
+        // the container is untouched (i.e. no new definitions or aliases)
+        $this->assertCount($definitionsBefore, $container->getDefinitions());
+        $this->assertCount($aliasesBefore, $container->getAliases());
     }
 }
diff --git a/Tests/DependencyInjection/Compiler/LoggingTranslatorPassTest.php b/Tests/DependencyInjection/Compiler/LoggingTranslatorPassTest.php
@@ -13,96 +13,69 @@
 
 use PHPUnit\Framework\TestCase;
 use Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\LoggingTranslatorPass;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\DependencyInjection\Reference;
 
 class LoggingTranslatorPassTest extends TestCase
 {
     public function testProcess()
     {
-        $definition = $this->getMockBuilder('Symfony\Component\DependencyInjection\Definition')->getMock();
-        $container = $this->getMockBuilder('Symfony\Component\DependencyInjection\ContainerBuilder')->getMock();
-        $parameterBag = $this->getMockBuilder('Symfony\Component\DependencyInjection\ParameterBag\ParameterBagInterface')->getMock();
-
-        $container->expects($this->exactly(2))
-            ->method('hasAlias')
-            ->will($this->returnValue(true));
-
-        $container->expects($this->once())
-            ->method('getParameter')
-            ->will($this->returnValue(true));
-
-        $container->expects($this->once())
-            ->method('getAlias')
-            ->will($this->returnValue('translation.default'));
-
-        $container->expects($this->exactly(3))
-            ->method('getDefinition')
-            ->will($this->returnValue($definition));
-
-        $container->expects($this->once())
-            ->method('hasParameter')
-            ->with('translator.logging')
-            ->will($this->returnValue(true));
-
-        $definition->expects($this->once())
-            ->method('getClass')
-            ->will($this->returnValue('Symfony\Bundle\FrameworkBundle\Translation\Translator'));
-
-        $parameterBag->expects($this->once())
-            ->method('resolveValue')
-            ->will($this->returnValue("Symfony\Bundle\FrameworkBundle\Translation\Translator"));
-
-        $container->expects($this->once())
-            ->method('getParameterBag')
-            ->will($this->returnValue($parameterBag));
-
-        $container->expects($this->once())
-            ->method('getReflectionClass')
-            ->with('Symfony\Bundle\FrameworkBundle\Translation\Translator')
-            ->will($this->returnValue(new \ReflectionClass('Symfony\Bundle\FrameworkBundle\Translation\Translator')));
-
-        $definition->expects($this->once())
-            ->method('getTag')
-            ->with('container.service_subscriber')
-            ->willReturn(array(array('id' => 'translator'), array('id' => 'foo')));
-
-        $definition->expects($this->once())
-            ->method('clearTag')
-            ->with('container.service_subscriber');
-
-        $definition->expects($this->any())
-            ->method('addTag')
-            ->withConsecutive(
-                array('container.service_subscriber', array('id' => 'foo')),
-                array('container.service_subscriber', array('key' => 'translator', 'id' => 'translator.logging.inner'))
-            );
+        $container = new ContainerBuilder();
+        $container->setParameter('translator.logging', true);
+        $container->setParameter('translator.class', 'Symfony\Component\Translation\Translator');
+        $container->register('monolog.logger');
+        $container->setAlias('logger', 'monolog.logger');
+        $container->register('translator.default', '%translator.class%');
+        $container->register('translator.logging', '%translator.class%');
+        $container->setAlias('translator', 'translator.default');
+        $translationWarmerDefinition = $container->register('translation.warmer')
+            ->addArgument(new Reference('translator'))
+            ->addTag('container.service_subscriber', array('id' => 'translator'))
+            ->addTag('container.service_subscriber', array('id' => 'foo'));
 
         $pass = new LoggingTranslatorPass();
         $pass->process($container);
+
+        $this->assertEquals(
+            array('container.service_subscriber' => array(
+                array('id' => 'foo'),
+                array('key' => 'translator', 'id' => 'translator.logging.inner'),
+            )),
+            $translationWarmerDefinition->getTags()
+        );
     }
 
     public function testThatCompilerPassIsIgnoredIfThereIsNotLoggerDefinition()
     {
-        $container = $this->getMockBuilder('Symfony\Component\DependencyInjection\ContainerBuilder')->getMock();
-        $container->expects($this->once())
-            ->method('hasAlias')
-            ->will($this->returnValue(false));
+        $container = new ContainerBuilder();
+        $container->register('identity_translator');
+        $container->setAlias('translator', 'identity_translator');
+
+        $definitionsBefore = count($container->getDefinitions());
+        $aliasesBefore = count($container->getAliases());
 
         $pass = new LoggingTranslatorPass();
         $pass->process($container);
+
+        // the container is untouched (i.e. no new definitions or aliases)
+        $this->assertCount($definitionsBefore, $container->getDefinitions());
+        $this->assertCount($aliasesBefore, $container->getAliases());
     }
 
     public function testThatCompilerPassIsIgnoredIfThereIsNotTranslatorDefinition()
     {
-        $container = $this->getMockBuilder('Symfony\Component\DependencyInjection\ContainerBuilder')->getMock();
-        $container->expects($this->at(0))
-            ->method('hasAlias')
-            ->will($this->returnValue(true));
+        $container = new ContainerBuilder();
+        $container->register('monolog.logger');
+        $container->setAlias('logger', 'monolog.logger');
 
-        $container->expects($this->at(0))
-            ->method('hasAlias')
-            ->will($this->returnValue(false));
+        $definitionsBefore = count($container->getDefinitions());
+        $aliasesBefore = count($container->getAliases());
 
         $pass = new LoggingTranslatorPass();
         $pass->process($container);
+
+        // the container is untouched (i.e. no new definitions or aliases)
+        $this->assertCount($definitionsBefore, $container->getDefinitions());
+        $this->assertCount($aliasesBefore, $container->getAliases());
     }
 }
diff --git a/Tests/DependencyInjection/Compiler/PropertyInfoPassTest.php b/Tests/DependencyInjection/Compiler/PropertyInfoPassTest.php
@@ -57,24 +57,16 @@ public function provideTags()
 
     public function testReturningEmptyArrayWhenNoService()
     {
-        $container = $this->getMockBuilder('Symfony\Component\DependencyInjection\ContainerBuilder')->setMethods(array('findTaggedServiceIds'))->getMock();
-
-        $container
-            ->expects($this->any())
-            ->method('findTaggedServiceIds')
-            ->will($this->returnValue(array()))
-        ;
+        $container = new ContainerBuilder();
+        $propertyInfoExtractorDefinition = $container->register('property_info')
+            ->setArguments(array(array(), array(), array(), array()));
 
         $propertyInfoPass = new PropertyInfoPass();
+        $propertyInfoPass->process($container);
 
-        $method = new \ReflectionMethod(
-            'Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\PropertyInfoPass',
-            'findAndSortTaggedServices'
-        );
-        $method->setAccessible(true);
-
-        $actual = $method->invoke($propertyInfoPass, 'tag', $container);
-
-        $this->assertEquals(array(), $actual);
+        $this->assertEquals(new IteratorArgument(array()), $propertyInfoExtractorDefinition->getArgument(0));
+        $this->assertEquals(new IteratorArgument(array()), $propertyInfoExtractorDefinition->getArgument(1));
+        $this->assertEquals(new IteratorArgument(array()), $propertyInfoExtractorDefinition->getArgument(2));
+        $this->assertEquals(new IteratorArgument(array()), $propertyInfoExtractorDefinition->getArgument(3));
     }
 }
diff --git a/Tests/DependencyInjection/Compiler/SerializerPassTest.php b/Tests/DependencyInjection/Compiler/SerializerPassTest.php
@@ -25,48 +25,30 @@
  */
 class SerializerPassTest extends TestCase
 {
+    /**
+     * @expectedException \RuntimeException
+     * @expectedExceptionMessage You must tag at least one service as "serializer.normalizer" to use the "serializer" service
+     */
     public function testThrowExceptionWhenNoNormalizers()
     {
-        $container = $this->getMockBuilder('Symfony\Component\DependencyInjection\ContainerBuilder')->setMethods(array('hasDefinition', 'findTaggedServiceIds'))->getMock();
-
-        $container->expects($this->once())
-            ->method('hasDefinition')
-            ->with('serializer')
-            ->will($this->returnValue(true));
-
-        $container->expects($this->once())
-            ->method('findTaggedServiceIds')
-            ->with('serializer.normalizer')
-            ->will($this->returnValue(array()));
-
-        $this->{method_exists($this, $_ = 'expectException') ? $_ : 'setExpectedException'}('RuntimeException');
+        $container = new ContainerBuilder();
+        $container->register('serializer');
 
         $serializerPass = new SerializerPass();
         $serializerPass->process($container);
     }
 
+    /**
+     * @expectedException \RuntimeException
+     * @expectedExceptionMessage You must tag at least one service as "serializer.encoder" to use the "serializer" service
+     */
     public function testThrowExceptionWhenNoEncoders()
     {
-        $definition = $this->getMockBuilder('Symfony\Component\DependencyInjection\Definition')->getMock();
-        $container = $this->getMockBuilder('Symfony\Component\DependencyInjection\ContainerBuilder')->setMethods(array('hasDefinition', 'findTaggedServiceIds', 'getDefinition'))->getMock();
-
-        $container->expects($this->once())
-            ->method('hasDefinition')
-            ->with('serializer')
-            ->will($this->returnValue(true));
-
-        $container->expects($this->any())
-            ->method('findTaggedServiceIds')
-            ->will($this->onConsecutiveCalls(
-                    array('n' => array('serializer.normalizer')),
-                    array()
-              ));
-
-        $container->expects($this->any())
-            ->method('getDefinition')
-            ->will($this->returnValue($definition));
-
-        $this->{method_exists($this, $_ = 'expectException') ? $_ : 'setExpectedException'}('RuntimeException');
+        $container = new ContainerBuilder();
+        $container->register('serializer')
+            ->addArgument(array())
+            ->addArgument(array());
+        $container->register('normalizer')->addTag('serializer.normalizer');
 
         $serializerPass = new SerializerPass();
         $serializerPass->process($container);
diff --git a/Tests/DependencyInjection/Compiler/UnusedTagsPassTest.php b/Tests/DependencyInjection/Compiler/UnusedTagsPassTest.php
@@ -13,31 +13,22 @@
 
 use PHPUnit\Framework\TestCase;
 use Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\UnusedTagsPass;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
 
 class UnusedTagsPassTest extends TestCase
 {
     public function testProcess()
     {
         $pass = new UnusedTagsPass();
 
-        $container = $this->getMockBuilder('Symfony\Component\DependencyInjection\ContainerBuilder')->setMethods(array('findTaggedServiceIds', 'findUnusedTags', 'findTags', 'log'))->getMock();
-        $container->expects($this->once())
-            ->method('log')
-            ->with($pass, 'Tag "kenrel.event_subscriber" was defined on service(s) "foo", "bar", but was never used. Did you mean "kernel.event_subscriber"?');
-        $container->expects($this->once())
-            ->method('findTags')
-            ->will($this->returnValue(array('kenrel.event_subscriber')));
-        $container->expects($this->once())
-            ->method('findUnusedTags')
-            ->will($this->returnValue(array('kenrel.event_subscriber', 'form.type')));
-        $container->expects($this->once())
-            ->method('findTaggedServiceIds')
-            ->with('kenrel.event_subscriber')
-            ->will($this->returnValue(array(
-                'foo' => array(),
-                'bar' => array(),
-            )));
+        $container = new ContainerBuilder();
+        $container->register('foo')
+            ->addTag('kenrel.event_subscriber');
+        $container->register('bar')
+            ->addTag('kenrel.event_subscriber');
 
         $pass->process($container);
+
+        $this->assertSame(array(sprintf('%s: Tag "kenrel.event_subscriber" was defined on service(s) "foo", "bar", but was never used. Did you mean "kernel.event_subscriber"?', UnusedTagsPass::class)), $container->getCompiler()->getLog());
     }
 }
diff --git a/Tests/Validator/ConstraintValidatorFactoryTest.php b/Tests/Validator/ConstraintValidatorFactoryTest.php

Original file line number	Diff line number	Diff line change
`@@ -44,13 +44,16 @@ public function testThatCheckersAreProcessedInPriorityOrder()`
`44`	`44`
`45`	`45`	`public function testThatCheckersCanBeMissing()`
`46`	`46`	`{`
`47`		`- $container = $this->getMockBuilder('Symfony\Component\DependencyInjection\ContainerBuilder')->setMethods(array('findTaggedServiceIds'))->getMock();`
	`47`	`+ $container = new ContainerBuilder();`
`48`	`48`
`49`		`- $container->expects($this->atLeastOnce())`
`50`		`- ->method('findTaggedServiceIds')`
`51`		`- ->will($this->returnValue(array()));`
	`49`	`+ $definitionsBefore = count($container->getDefinitions());`
	`50`	`+ $aliasesBefore = count($container->getAliases());`
`52`	`51`
`53`	`52`	`$pass = new ConfigCachePass();`
`54`	`53`	`$pass->process($container);`
	`54`	`+`
	`55`	`+ // the container is untouched (i.e. no new definitions or aliases)`
	`56`	`+ $this->assertCount($definitionsBefore, $container->getDefinitions());`
	`57`	`+ $this->assertCount($aliasesBefore, $container->getAliases());`
`55`	`58`	`}`
`56`	`59`	`}`