Merge branch '4.4'

* 4.4:
  [4.3] Remove unused local variables

Author: nicolas-grekas

DependencyInjection/FrameworkExtension.php

@@ -937,8 +937,6 @@ private function registerAssetsConfiguration(array $config, ContainerBuilder $co
     {
         $loader->load('assets.xml');
 
-        $defaultVersion = null;
-
         if ($config['version_strategy']) {
             $defaultVersion = new Reference($config['version_strategy']);
         } else {

Routing/DelegatingLoader.php

@@ -81,11 +81,6 @@ public function load($resource, string $type = null)
                 continue;
             }
 
-            if (1 === substr_count($controller, ':')) {
-                $nonDeprecatedNotation = str_replace(':', '::', $controller);
-                // TODO deprecate this in 5.1
-            }
-
             $route->setDefault('_controller', $controller);
         }
 

Tests/Functional/ContainerDumpTest.php

@@ -18,14 +18,14 @@ class ContainerDumpTest extends AbstractWebTestCase
 {
     public function testContainerCompilationInDebug()
     {
-        $client = $this->createClient(['test_case' => 'ContainerDump', 'root_config' => 'config.yml']);
+        $this->createClient(['test_case' => 'ContainerDump', 'root_config' => 'config.yml']);
 
         $this->assertTrue(static::$container->has('serializer'));
     }
 
     public function testContainerCompilation()
     {
-        $client = $this->createClient(['test_case' => 'ContainerDump', 'root_config' => 'config.yml', 'debug' => false]);
+        $this->createClient(['test_case' => 'ContainerDump', 'root_config' => 'config.yml', 'debug' => false]);
 
         $this->assertTrue(static::$container->has('serializer'));
     }