minor #19736 [FrameworkBundle][Security] Remove useless mocks (Ener-Getick)

fabpot · fabpot · commit a6c9489f6209 · 2016-08-25T10:52:51.000-07:00
This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle][Security] Remove useless mocks | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Removes mocks causing issues in symfony/symfony#19734. Commits ------- fcd3345 [FrameworkBundle][Security] Remove useless mocks
diff --git a/Tests/Templating/DelegatingEngineTest.php b/Tests/Templating/DelegatingEngineTest.php
@@ -12,6 +12,7 @@
 namespace Symfony\Bundle\FrameworkBundle\Tests\Templating;
 
 use Symfony\Bundle\FrameworkBundle\Templating\DelegatingEngine;
+use Symfony\Component\HttpFoundation\Response;
 
 class DelegatingEngineTest extends \PHPUnit_Framework_TestCase
 {
@@ -60,7 +61,7 @@ public function testGetInvalidEngine()
 
     public function testRenderResponseWithFrameworkEngine()
     {
-        $response = $this->getMock('Symfony\Component\HttpFoundation\Response');
+        $response = new Response();
         $engine = $this->getFrameworkEngineMock('template.php', true);
         $engine->expects($this->once())
             ->method('renderResponse')

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,7 @@`
`12`	`12`	`namespace Symfony\Bundle\FrameworkBundle\Tests\Templating;`
`13`	`13`
`14`	`14`	`use Symfony\Bundle\FrameworkBundle\Templating\DelegatingEngine;`
	`15`	`+use Symfony\Component\HttpFoundation\Response;`
`15`	`16`
`16`	`17`	`class DelegatingEngineTest extends \PHPUnit_Framework_TestCase`
`17`	`18`	`{`
`@@ -60,7 +61,7 @@ public function testGetInvalidEngine()`
`60`	`61`
`61`	`62`	`public function testRenderResponseWithFrameworkEngine()`
`62`	`63`	`{`
`63`		`- $response = $this->getMock('Symfony\Component\HttpFoundation\Response');`
	`64`	`+ $response = new Response();`
`64`	`65`	`$engine = $this->getFrameworkEngineMock('template.php', true);`
`65`	`66`	`$engine->expects($this->once())`
`66`	`67`	`->method('renderResponse')`