Fix json-encoding when JSON_THROW_ON_ERROR is used

nicolas-grekas · nicolas-grekas · commit b9ffeff1da53 · 2019-06-05T13:33:52.000+02:00
diff --git a/Console/Descriptor/JsonDescriptor.php b/Console/Descriptor/JsonDescriptor.php
@@ -186,11 +186,6 @@ private function writeData(array $data, array $options)
     {
         $flags = isset($options['json_encoding']) ? $options['json_encoding'] : 0;
 
-        if (\PHP_VERSION_ID >= 70300 && (JSON_THROW_ON_ERROR & $flags)) {
-            // Work around https://bugs.php.net/77997
-            json_encode(null);
-        }
-
         $this->write(json_encode($data, $flags | JSON_PRETTY_PRINT)."\n");
     }
 

Original file line number	Diff line number	Diff line change
`@@ -186,11 +186,6 @@ private function writeData(array $data, array $options)`
`186`	`186`	`{`
`187`	`187`	`$flags = isset($options['json_encoding']) ? $options['json_encoding'] : 0;`
`188`	`188`
`189`		`- if (\PHP_VERSION_ID >= 70300 && (JSON_THROW_ON_ERROR & $flags)) {`
`190`		`- // Work around https://bugs.php.net/77997`
`191`		`- json_encode(null);`
`192`		`- }`
`193`		`-`
`194`	`189`	`$this->write(json_encode($data, $flags \| JSON_PRETTY_PRINT)."\n");`
`195`	`190`	`}`
`196`	`191`