Skip to content

Commit e3ab595

Browse files
committed
Merge branch '2.3'
* 2.3: [Form] fixes empty file-inputs get treated as extra field return 0 if there is no valid data [DependencyInjection] fixed regression where setting a service to null did not trigger a re-creation of the service when getting it [DependencyInjection] fixed #8570 fixed file permission The ignoreAttributes itself should be ignored, too. [Tests] Tests on php 5.5 should pass [Twig] fixed TwigEngine::exists() method when a template contains a syntax error (closes #88546)
2 parents 49a0f80 + 79acc23 commit e3ab595

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

Controller/RedirectController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public function redirectAction(Request $request, $route, $permanent = false, $ig
4949
$attributes = array();
5050
if (false === $ignoreAttributes || is_array($ignoreAttributes)) {
5151
$attributes = $request->attributes->get('_route_params');
52-
unset($attributes['route'], $attributes['permanent']);
52+
unset($attributes['route'], $attributes['permanent'], $attributes['ignoreAttributes']);
5353
if ($ignoreAttributes) {
5454
$attributes = array_diff_key($attributes, array_flip($ignoreAttributes));
5555
}

Tests/Controller/RedirectControllerTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ public function testRoute($permanent, $ignoreAttributes, $expectedCode, $expecte
5353
'route' => $route,
5454
'permanent' => $permanent,
5555
'additional-parameter' => 'value',
56+
'ignoreAttributes' => $ignoreAttributes
5657
),
5758
);
5859

0 commit comments

Comments
 (0)