[Notifier] Disable notifications on failed messages by default

Author: fabpot

DependencyInjection/Configuration.php

@@ -1516,6 +1516,7 @@ private function addNotifierSection(ArrayNodeDefinition $rootNode)
                             ->prototype('scalar')->end()
                         ->end()
                     ->end()
+                    ->booleanNode('notification_on_failed_messages')->defaultFalse()->end()
                     ->children()
                         ->arrayNode('channel_policy')
                             ->useAttributeAsKey('name')

DependencyInjection/FrameworkExtension.php

@@ -1934,9 +1934,11 @@ private function registerNotifierConfiguration(array $config, ContainerBuilder $
             $container->removeDefinition('notifier.channel.email');
         }
 
-        if (!$this->messengerConfigEnabled) {
-            $container->removeDefinition('notifier.failed_message_listener');
-        } else {
+        if ($this->messengerConfigEnabled) {
+            if ($config['notification_on_failed_messages']) {
+                $container->getDefinition('notifier.failed_message_listener')->addTag('kernel.event_subscriber');
+            }
+
             // as we have a bus, the channels don't need the transports
             $container->getDefinition('notifier.channel.chat')->setArgument(0, null);
             $container->getDefinition('notifier.channel.email')->setArgument(0, null);

Resources/config/notifier.xml

@@ -44,7 +44,6 @@
 
         <service id="notifier.failed_message_listener" class="Symfony\Component\Notifier\EventListener\SendFailedMessageToNotifierListener">
             <argument type="service" id="notifier" />
-            <tag name="kernel.event_subscriber" />
         </service>
 
         <!-- chatter -->