Skip to content

Commit f9f431f

Browse files
committed
Remove unused local variables in tests
1 parent e029ca9 commit f9f431f

File tree

8 files changed

+6
-10
lines changed

8 files changed

+6
-10
lines changed

Console/Descriptor/TextDescriptor.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -425,7 +425,6 @@ private function renderEventListenerTable(EventDispatcherInterface $eventDispatc
425425
$tableHeaders = ['Order', 'Callable', 'Priority'];
426426
$tableRows = [];
427427

428-
$order = 1;
429428
foreach ($eventListeners as $order => $listener) {
430429
$tableRows[] = [sprintf('#%d', $order + 1), $this->formatCallable($listener), $eventDispatcher->getListenerPriority($event, $listener)];
431430
}

DependencyInjection/FrameworkExtension.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1043,8 +1043,6 @@ private function registerAssetsConfiguration(array $config, ContainerBuilder $co
10431043
$container->getDefinition('assets.url_package')->setPrivate(true);
10441044
$container->getDefinition('assets.static_version_strategy')->setPrivate(true);
10451045

1046-
$defaultVersion = null;
1047-
10481046
if ($config['version_strategy']) {
10491047
$defaultVersion = new Reference($config['version_strategy']);
10501048
} else {

Tests/Controller/ControllerTraitTest.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -277,8 +277,7 @@ public function testFileWhichDoesNotExist()
277277
$this->expectException('Symfony\Component\HttpFoundation\File\Exception\FileNotFoundException');
278278
$controller = $this->createController();
279279

280-
/* @var BinaryFileResponse $response */
281-
$response = $controller->file('some-file.txt', 'test.php');
280+
$controller->file('some-file.txt', 'test.php');
282281
}
283282

284283
public function testIsGranted()

Tests/DependencyInjection/Compiler/AddConstraintValidatorsPassTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public function testAbstractConstraintValidator()
5151
$this->expectException('InvalidArgumentException');
5252
$this->expectExceptionMessage('The service "my_abstract_constraint_validator" tagged "validator.constraint_validator" must not be abstract.');
5353
$container = new ContainerBuilder();
54-
$validatorFactory = $container->register('validator.validator_factory')
54+
$container->register('validator.validator_factory')
5555
->addArgument([]);
5656

5757
$container->register('my_abstract_constraint_validator')

Tests/DependencyInjection/FrameworkExtensionTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ public function testWorkflows()
251251
*/
252252
public function testDeprecatedWorkflowMissingType()
253253
{
254-
$container = $this->createContainerFromFile('workflows_without_type');
254+
$this->createContainerFromFile('workflows_without_type');
255255
}
256256

257257
public function testWorkflowCannotHaveBothTypeAndService()

Tests/Functional/Bundle/TestBundle/DependencyInjection/TestExtension.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ class TestExtension extends Extension implements PrependExtensionInterface
2626
public function load(array $configs, ContainerBuilder $container)
2727
{
2828
$configuration = $this->getConfiguration($configs, $container);
29-
$config = $this->processConfiguration($configuration, $configs);
29+
$this->processConfiguration($configuration, $configs);
3030

3131
$container->setAlias('test.annotation_reader', new Alias('annotation_reader', true));
3232
}

Tests/Functional/SessionTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public function testFlash($config, $insulate)
5959
}
6060

6161
// set flash
62-
$crawler = $client->request('GET', '/session_setflash/Hello%20world.');
62+
$client->request('GET', '/session_setflash/Hello%20world.');
6363

6464
// check flash displays on redirect
6565
$this->assertStringContainsString('Hello world.', $client->followRedirect()->text());

Tests/Translation/TranslatorTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ public function testGetDefaultLocaleOmittingLocaleWithPsrContainer()
162162
$this->expectException('InvalidArgumentException');
163163
$this->expectExceptionMessage('Missing third $defaultLocale argument.');
164164
$container = $this->getMockBuilder(ContainerInterface::class)->getMock();
165-
$translator = new Translator($container, new MessageFormatter());
165+
new Translator($container, new MessageFormatter());
166166
}
167167

168168
/**

0 commit comments

Comments
 (0)