Skip to content

Commit fbecbe5

Browse files
Merge branch '3.1'
* 3.1: [2.8][PhpUnitBridge] Drop ErrorAssert in favor of @expectedDeprecation [3.1][PhpUnitBridge] Drop ErrorAssert in favor of @expectedDeprecation
2 parents 189e0ad + e22f884 commit fbecbe5

File tree

2 files changed

+11
-17
lines changed

2 files changed

+11
-17
lines changed

Tests/DependencyInjection/FrameworkExtensionTest.php

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111

1212
namespace Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection;
1313

14-
use Symfony\Bridge\PhpUnit\ErrorAssert;
1514
use Symfony\Bundle\FrameworkBundle\Tests\TestCase;
1615
use Symfony\Bundle\FrameworkBundle\DependencyInjection\FrameworkExtension;
1716
use Symfony\Component\Cache\Adapter\ApcuAdapter;
@@ -566,19 +565,17 @@ public function testSerializerCacheDisabled()
566565

567566
/**
568567
* @group legacy
569-
* @requires function Symfony\Bridge\PhpUnit\ErrorAssert::assertDeprecationsAreTriggered
568+
* @expectedDeprecation The "framework.serializer.cache" option is deprecated %s.
570569
*/
571570
public function testDeprecatedSerializerCacheOption()
572571
{
573-
ErrorAssert::assertDeprecationsAreTriggered('The "framework.serializer.cache" option is deprecated', function () {
574-
$container = $this->createContainerFromFile('serializer_legacy_cache', array('kernel.debug' => true, 'kernel.container_class' => __CLASS__));
572+
$container = $this->createContainerFromFile('serializer_legacy_cache', array('kernel.debug' => true, 'kernel.container_class' => __CLASS__));
575573

576-
$this->assertFalse($container->hasDefinition('serializer.mapping.cache_class_metadata_factory'));
577-
$this->assertTrue($container->hasDefinition('serializer.mapping.class_metadata_factory'));
574+
$this->assertFalse($container->hasDefinition('serializer.mapping.cache_class_metadata_factory'));
575+
$this->assertTrue($container->hasDefinition('serializer.mapping.class_metadata_factory'));
578576

579-
$cache = $container->getDefinition('serializer.mapping.class_metadata_factory')->getArgument(1);
580-
$this->assertEquals(new Reference('foo'), $cache);
581-
});
577+
$cache = $container->getDefinition('serializer.mapping.class_metadata_factory')->getArgument(1);
578+
$this->assertEquals(new Reference('foo'), $cache);
582579
}
583580

584581
public function testAssetHelperWhenAssetsAreEnabled()

Tests/Templating/TemplateNameParserTest.php

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111

1212
namespace Symfony\Bundle\FrameworkBundle\Tests\Templating;
1313

14-
use Symfony\Bridge\PhpUnit\ErrorAssert;
1514
use Symfony\Bundle\FrameworkBundle\Tests\TestCase;
1615
use Symfony\Bundle\FrameworkBundle\Templating\TemplateNameParser;
1716
use Symfony\Bundle\FrameworkBundle\Templating\TemplateReference;
@@ -86,17 +85,15 @@ public function testParseValidNameWithNotFoundBundle()
8685
/**
8786
* @group legacy
8887
* @dataProvider provideAbsolutePaths
89-
* @requires function Symfony\Bridge\PhpUnit\ErrorAssert::assertDeprecationsAreTriggered
88+
* @expectedDeprecation Absolute template path support is deprecated since Symfony 3.1 and will be removed in 4.0.
9089
*/
9190
public function testAbsolutePathsAreDeprecated($name, $logicalName, $path, $ref)
9291
{
93-
ErrorAssert::assertDeprecationsAreTriggered('Absolute template path support is deprecated since Symfony 3.1 and will be removed in 4.0.', function () use ($name, $logicalName, $path, $ref) {
94-
$template = $this->parser->parse($name);
92+
$template = $this->parser->parse($name);
9593

96-
$this->assertSame($ref->getLogicalName(), $template->getLogicalName());
97-
$this->assertSame($logicalName, $template->getLogicalName());
98-
$this->assertSame($path, $template->getPath());
99-
});
94+
$this->assertSame($ref->getLogicalName(), $template->getLogicalName());
95+
$this->assertSame($logicalName, $template->getLogicalName());
96+
$this->assertSame($path, $template->getPath());
10097
}
10198

10299
public function provideAbsolutePaths()

0 commit comments

Comments
 (0)