[HttpClient] Fix shared connections not being freed on PHP < 8

nicolas-grekas · nicolas-grekas · commit 653dc41a26bd · 2022-08-01T19:57:58.000+02:00
diff --git a/Internal/CurlClientState.php b/Internal/CurlClientState.php
@@ -96,7 +96,7 @@ public function reset()
         curl_share_setopt($this->share, \CURLSHOPT_SHARE, \CURL_LOCK_DATA_DNS);
         curl_share_setopt($this->share, \CURLSHOPT_SHARE, \CURL_LOCK_DATA_SSL_SESSION);
 
-        if (\defined('CURL_LOCK_DATA_CONNECT')) {
+        if (\defined('CURL_LOCK_DATA_CONNECT') && \PHP_VERSION_ID >= 80000) {
             curl_share_setopt($this->share, \CURLSHOPT_SHARE, \CURL_LOCK_DATA_CONNECT);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ public function reset()`
`96`	`96`	`curl_share_setopt($this->share, \CURLSHOPT_SHARE, \CURL_LOCK_DATA_DNS);`
`97`	`97`	`curl_share_setopt($this->share, \CURLSHOPT_SHARE, \CURL_LOCK_DATA_SSL_SESSION);`
`98`	`98`
`99`		`- if (\defined('CURL_LOCK_DATA_CONNECT')) {`
	`99`	`+ if (\defined('CURL_LOCK_DATA_CONNECT') && \PHP_VERSION_ID >= 80000) {`
`100`	`100`	`curl_share_setopt($this->share, \CURLSHOPT_SHARE, \CURL_LOCK_DATA_CONNECT);`
`101`	`101`	`}`
`102`	`102`	`}`