[HttpClient] fallbackto CURLMOPT_MAXCONNECTS when CURLMOPT_MAX_HOST_CONNECTIONS is not available

nicolas-grekas · nicolas-grekas · commit e5aea2bb0d7e · 2019-09-08T18:59:44.000+02:00
diff --git a/CurlHttpClient.php b/CurlHttpClient.php
@@ -72,7 +72,10 @@ public function __construct(array $defaultOptions = [], int $maxHostConnections
             curl_multi_setopt($this->multi->handle, CURLMOPT_PIPELINING, CURLPIPE_MULTIPLEX);
         }
         if (\defined('CURLMOPT_MAX_HOST_CONNECTIONS')) {
-            curl_multi_setopt($this->multi->handle, CURLMOPT_MAX_HOST_CONNECTIONS, 0 < $maxHostConnections ? $maxHostConnections : PHP_INT_MAX);
+            $maxHostConnections = curl_multi_setopt($this->multi->handle, CURLMOPT_MAX_HOST_CONNECTIONS, 0 < $maxHostConnections ? $maxHostConnections : PHP_INT_MAX) ? 0 : $maxHostConnections;
+        }
+        if (\defined('CURLMOPT_MAXCONNECTS') && 0 < $maxHostConnections) {
+            curl_multi_setopt($this->multi->handle, CURLMOPT_MAXCONNECTS, $maxHostConnections);
         }
 
         // Skip configuring HTTP/2 push when it's unsupported or buggy, see https://bugs.php.net/77535

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,10 @@ public function __construct(array $defaultOptions = [], int $maxHostConnections`
`72`	`72`	`curl_multi_setopt($this->multi->handle, CURLMOPT_PIPELINING, CURLPIPE_MULTIPLEX);`
`73`	`73`	`}`
`74`	`74`	`if (\defined('CURLMOPT_MAX_HOST_CONNECTIONS')) {`
`75`		`- curl_multi_setopt($this->multi->handle, CURLMOPT_MAX_HOST_CONNECTIONS, 0 < $maxHostConnections ? $maxHostConnections : PHP_INT_MAX);`
	`75`	`+ $maxHostConnections = curl_multi_setopt($this->multi->handle, CURLMOPT_MAX_HOST_CONNECTIONS, 0 < $maxHostConnections ? $maxHostConnections : PHP_INT_MAX) ? 0 : $maxHostConnections;`
	`76`	`+ }`
	`77`	`+ if (\defined('CURLMOPT_MAXCONNECTS') && 0 < $maxHostConnections) {`
	`78`	`+ curl_multi_setopt($this->multi->handle, CURLMOPT_MAXCONNECTS, $maxHostConnections);`
`76`	`79`	`}`
`77`	`80`
`78`	`81`	`// Skip configuring HTTP/2 push when it's unsupported or buggy, see https://bugs.php.net/77535`