Replace FILTER_VALIDATE_BOOLEAN by FILTER_VALIDATE_BOOL

Author: deguif

ParameterBag.php

@@ -138,7 +138,7 @@ public function getInt(string $key, int $default = 0): int
      */
     public function getBoolean(string $key, bool $default = false): bool
     {
-        return $this->filter($key, $default, \FILTER_VALIDATE_BOOLEAN);
+        return $this->filter($key, $default, \FILTER_VALIDATE_BOOL);
     }
 
     /**

Session/Storage/Handler/AbstractSessionHandler.php

@@ -86,7 +86,7 @@ public function write(string $sessionId, string $data): bool
 
     public function destroy(string $sessionId): bool
     {
-        if (!headers_sent() && filter_var(\ini_get('session.use_cookies'), \FILTER_VALIDATE_BOOLEAN)) {
+        if (!headers_sent() && filter_var(\ini_get('session.use_cookies'), \FILTER_VALIDATE_BOOL)) {
             if (!isset($this->sessionName)) {
                 throw new \LogicException(sprintf('Session name cannot be empty, did you forget to call "parent::open()" in "%s"?.', static::class));
             }

Session/Storage/Handler/PdoSessionHandler.php

@@ -593,7 +593,7 @@ protected function doRead(string $sessionId): string
                 throw new \RuntimeException('Failed to read session: INSERT reported a duplicate id but next SELECT did not return any data.');
             }
 
-            if (!filter_var(\ini_get('session.use_strict_mode'), \FILTER_VALIDATE_BOOLEAN) && self::LOCK_TRANSACTIONAL === $this->lockMode && 'sqlite' !== $this->driver) {
+            if (!filter_var(\ini_get('session.use_strict_mode'), \FILTER_VALIDATE_BOOL) && self::LOCK_TRANSACTIONAL === $this->lockMode && 'sqlite' !== $this->driver) {
                 // In strict mode, session fixation is not possible: new sessions always start with a unique
                 // random id, so that concurrency is not possible and this code path can be skipped.
                 // Exclusive-reading of non-existent rows does not block, so we need to do an insert to block

Session/Storage/NativeSessionStorage.php

@@ -128,7 +128,7 @@ public function start(): bool
             throw new \RuntimeException('Failed to start the session: already started by PHP.');
         }
 
-        if (filter_var(\ini_get('session.use_cookies'), \FILTER_VALIDATE_BOOLEAN) && headers_sent($file, $line)) {
+        if (filter_var(\ini_get('session.use_cookies'), \FILTER_VALIDATE_BOOL) && headers_sent($file, $line)) {
             throw new \RuntimeException(sprintf('Failed to start the session because headers have already been sent by "%s" at line %d.', $file, $line));
         }
 

Tests/Fixtures/response-functional/common.inc

@@ -22,7 +22,7 @@ error_reporting(-1);
 ini_set('html_errors', 0);
 ini_set('display_errors', 1);
 
-if (filter_var(ini_get('xdebug.default_enable'), FILTER_VALIDATE_BOOLEAN)) {
+if (filter_var(ini_get('xdebug.default_enable'), FILTER_VALIDATE_BOOL)) {
     xdebug_disable();
 }
 

Tests/Session/Storage/Handler/PdoSessionHandlerTest.php

@@ -147,7 +147,7 @@ public function testReadConvertsStreamToString()
 
     public function testReadLockedConvertsStreamToString()
     {
-        if (filter_var(\ini_get('session.use_strict_mode'), \FILTER_VALIDATE_BOOLEAN)) {
+        if (filter_var(\ini_get('session.use_strict_mode'), \FILTER_VALIDATE_BOOL)) {
             $this->markTestSkipped('Strict mode needs no locking for new sessions.');
         }