Skip to content

Commit 31bfc95

Browse files
committed
minor #13586 [DX][Config] Changed return type definition for some methods of NodeDefinition (Strate)
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #13586). Discussion ---------- [DX][Config] Changed return type definition for some methods of NodeDefinition | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12280 | License | MIT Discussed in #12280 Commits ------- 89ca585 Changed return type definition for some methods of NodeDefinition
2 parents e18d2ad + 89ca585 commit 31bfc95

File tree

2 files changed

+19
-14
lines changed

2 files changed

+19
-14
lines changed

src/Symfony/Component/Config/Definition/Builder/EnumNodeDefinition.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,11 @@ class EnumNodeDefinition extends ScalarNodeDefinition
2222
{
2323
private $values;
2424

25+
/**
26+
* @param array $values
27+
*
28+
* @return EnumNodeDefinition|$this
29+
*/
2530
public function values(array $values)
2631
{
2732
$values = array_unique($values);

src/Symfony/Component/Config/Definition/Builder/NodeDefinition.php

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public function __construct($name, NodeParentInterface $parent = null)
5959
*
6060
* @param NodeParentInterface $parent The parent
6161
*
62-
* @return NodeDefinition
62+
* @return NodeDefinition|$this
6363
*/
6464
public function setParent(NodeParentInterface $parent)
6565
{
@@ -73,7 +73,7 @@ public function setParent(NodeParentInterface $parent)
7373
*
7474
* @param string $info The info text
7575
*
76-
* @return NodeDefinition
76+
* @return NodeDefinition|$this
7777
*/
7878
public function info($info)
7979
{
@@ -85,7 +85,7 @@ public function info($info)
8585
*
8686
* @param string|array $example
8787
*
88-
* @return NodeDefinition
88+
* @return NodeDefinition|$this
8989
*/
9090
public function example($example)
9191
{
@@ -98,7 +98,7 @@ public function example($example)
9898
* @param string $key
9999
* @param mixed $value
100100
*
101-
* @return NodeDefinition
101+
* @return NodeDefinition|$this
102102
*/
103103
public function attribute($key, $value)
104104
{
@@ -149,7 +149,7 @@ public function getNode($forceRootNode = false)
149149
*
150150
* @param mixed $value The default value
151151
*
152-
* @return NodeDefinition
152+
* @return NodeDefinition|$this
153153
*/
154154
public function defaultValue($value)
155155
{
@@ -162,7 +162,7 @@ public function defaultValue($value)
162162
/**
163163
* Sets the node as required.
164164
*
165-
* @return NodeDefinition
165+
* @return NodeDefinition|$this
166166
*/
167167
public function isRequired()
168168
{
@@ -176,7 +176,7 @@ public function isRequired()
176176
*
177177
* @param mixed $value
178178
*
179-
* @return NodeDefinition
179+
* @return NodeDefinition|$this
180180
*/
181181
public function treatNullLike($value)
182182
{
@@ -190,7 +190,7 @@ public function treatNullLike($value)
190190
*
191191
* @param mixed $value
192192
*
193-
* @return NodeDefinition
193+
* @return NodeDefinition|$this
194194
*/
195195
public function treatTrueLike($value)
196196
{
@@ -204,7 +204,7 @@ public function treatTrueLike($value)
204204
*
205205
* @param mixed $value
206206
*
207-
* @return NodeDefinition
207+
* @return NodeDefinition|$this
208208
*/
209209
public function treatFalseLike($value)
210210
{
@@ -216,7 +216,7 @@ public function treatFalseLike($value)
216216
/**
217217
* Sets null as the default value.
218218
*
219-
* @return NodeDefinition
219+
* @return NodeDefinition|$this
220220
*/
221221
public function defaultNull()
222222
{
@@ -226,7 +226,7 @@ public function defaultNull()
226226
/**
227227
* Sets true as the default value.
228228
*
229-
* @return NodeDefinition
229+
* @return NodeDefinition|$this
230230
*/
231231
public function defaultTrue()
232232
{
@@ -236,7 +236,7 @@ public function defaultTrue()
236236
/**
237237
* Sets false as the default value.
238238
*
239-
* @return NodeDefinition
239+
* @return NodeDefinition|$this
240240
*/
241241
public function defaultFalse()
242242
{
@@ -256,7 +256,7 @@ public function beforeNormalization()
256256
/**
257257
* Denies the node value being empty.
258258
*
259-
* @return NodeDefinition
259+
* @return NodeDefinition|$this
260260
*/
261261
public function cannotBeEmpty()
262262
{
@@ -284,7 +284,7 @@ public function validate()
284284
*
285285
* @param bool $deny Whether the overwriting is forbidden or not
286286
*
287-
* @return NodeDefinition
287+
* @return NodeDefinition|$this
288288
*/
289289
public function cannotBeOverwritten($deny = true)
290290
{

0 commit comments

Comments
 (0)