Skip to content

Commit 89f1c35

Browse files
committed
minor #18291 Fix copy-paste in PHPDoc comment text (guilliamxavier)
This PR was merged into the 2.3 branch. Discussion ---------- Fix copy-paste in PHPDoc comment text | Q | A | ------------- | --- | Branch? | 2.3+ (actually all branches from 2.0) | License | MIT In http://api.symfony.com/2.3/Symfony/Component/Form/DataTransformerInterface.html, compare the documentation (*emphasis* mine) respectively for `transform` and for `reverseTransform`: > Usually this will be *NULL*, but […] other empty values are possible as well (such as *empty strings*). > Usually this will be *an empty string*, but […] other empty values are possible as well (such as *empty strings*). This PR corrects the repetition in the latter, giving symmetry: > Usually this will be *NULL*, but […] other empty values are possible as well (such as *empty strings*). > Usually this will be *an empty string*, but […] other empty values are possible as well (such as *NULL*). _Note:_ For now I just changed `empty strings` to `NULL`, which is 9 characters shorter, should I also reformat the affected comment paragraph so that this line and the subsequent ones fill up to 80 columns (as was the case before the change, and is for `transform`)? Commits ------- 3f6e37e Fix copy-paste in PHPDoc comment text
2 parents e375161 + 3f6e37e commit 89f1c35

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/Symfony/Component/Form/DataTransformerInterface.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public function transform($value);
5858
*
5959
* This method must be able to deal with empty values. Usually this will
6060
* be an empty string, but depending on your implementation other empty
61-
* values are possible as well (such as empty strings). The reasoning behind
61+
* values are possible as well (such as NULL). The reasoning behind
6262
* this is that value transformers must be chainable. If the
6363
* reverseTransform() method of the first value transformer outputs an
6464
* empty string, the second value transformer must be able to process that

0 commit comments

Comments
 (0)