Merge branch '2.7' into 2.8

nicolas-grekas · nicolas-grekas · commit 91e0bda85132 · 2017-01-10T15:03:07.000+01:00
* 2.7:
  [DI] Dont share service when no id provided
  Fix Container and PhpDumper test inaccuracies
  [DI] Fix missing new line after private alias
  [ClassLoader] Throw an exception if the cache is not writeable
  Fixing regression in TwigEngine exception handling.
diff --git a/Tests/Bundle/BundleTest.php b/Tests/Bundle/BundleTest.php
@@ -56,7 +56,7 @@ public function testGetContainerExtensionWithInvalidClass()
     public function testHttpKernelRegisterCommandsIgnoresCommandsThatAreRegisteredAsServices()
     {
         $container = new ContainerBuilder();
-        $container->register('console.command.Symfony_Component_HttpKernel_Tests_Fixtures_ExtensionPresentBundle_Command_FooCommand', 'Symfony\Component\HttpKernel\Tests\Fixtures\ExtensionPresentBundle\Command\FooCommand');
+        $container->register('console.command.symfony_component_httpkernel_tests_fixtures_extensionpresentbundle_command_foocommand', 'Symfony\Component\HttpKernel\Tests\Fixtures\ExtensionPresentBundle\Command\FooCommand');
 
         $application = $this->getMockBuilder('Symfony\Component\Console\Application')->getMock();
         // add() is never called when the found command classes are already registered as services

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ public function testGetContainerExtensionWithInvalidClass()`
`56`	`56`	`public function testHttpKernelRegisterCommandsIgnoresCommandsThatAreRegisteredAsServices()`
`57`	`57`	`{`
`58`	`58`	`$container = new ContainerBuilder();`
`59`		`- $container->register('console.command.Symfony_Component_HttpKernel_Tests_Fixtures_ExtensionPresentBundle_Command_FooCommand', 'Symfony\Component\HttpKernel\Tests\Fixtures\ExtensionPresentBundle\Command\FooCommand');`
	`59`	`+ $container->register('console.command.symfony_component_httpkernel_tests_fixtures_extensionpresentbundle_command_foocommand', 'Symfony\Component\HttpKernel\Tests\Fixtures\ExtensionPresentBundle\Command\FooCommand');`
`60`	`60`
`61`	`61`	`$application = $this->getMockBuilder('Symfony\Component\Console\Application')->getMock();`
`62`	`62`	`// add() is never called when the found command classes are already registered as services`