Skip to content

Commit 92d035f

Browse files
peterrehmnicolas-grekas
authored andcommitted
Refactored other PHPUnit method calls to work with namespaced PHPUnit 6
1 parent 3c15bf6 commit 92d035f

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

Tests/ClientTest.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,8 @@ public function testFilterResponseConvertsCookies()
7474
$domResponse = $m->invoke($client, $response);
7575
try {
7676
$this->assertEquals($expected31[0], $domResponse->getHeader('Set-Cookie'));
77+
} catch (\PHPUnit\Framework\ExpectationFailedException $e) {
78+
$this->assertEquals($expected33[0], $domResponse->getHeader('Set-Cookie'));
7779
} catch (\PHPUnit_Framework_ExpectationFailedException $e) {
7880
$this->assertEquals($expected33[0], $domResponse->getHeader('Set-Cookie'));
7981
}
@@ -84,11 +86,15 @@ public function testFilterResponseConvertsCookies()
8486
$domResponse = $m->invoke($client, $response);
8587
try {
8688
$this->assertEquals($expected31[0], $domResponse->getHeader('Set-Cookie'));
89+
} catch (\PHPUnit\Framework\ExpectationFailedException $e) {
90+
$this->assertEquals($expected33[0], $domResponse->getHeader('Set-Cookie'));
8791
} catch (\PHPUnit_Framework_ExpectationFailedException $e) {
8892
$this->assertEquals($expected33[0], $domResponse->getHeader('Set-Cookie'));
8993
}
9094
try {
9195
$this->assertEquals($expected31, $domResponse->getHeader('Set-Cookie', false));
96+
} catch (\PHPUnit\Framework\ExpectationFailedException $e) {
97+
$this->assertEquals($expected33, $domResponse->getHeader('Set-Cookie', false));
9298
} catch (\PHPUnit_Framework_ExpectationFailedException $e) {
9399
$this->assertEquals($expected33, $domResponse->getHeader('Set-Cookie', false));
94100
}

Tests/Controller/ControllerResolverTest.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,12 @@ public function testGetControllerWithFunction()
118118
public function testGetControllerOnNonUndefinedFunction($controller, $exceptionName = null, $exceptionMessage = null)
119119
{
120120
$resolver = $this->createControllerResolver();
121-
$this->setExpectedException($exceptionName, $exceptionMessage);
121+
if (method_exists($this, 'expectException')) {
122+
$this->expectException($exceptionName);
123+
$this->expectExceptionMessage($exceptionMessage);
124+
} else {
125+
$this->setExpectedException($exceptionName, $exceptionMessage);
126+
}
122127

123128
$request = Request::create('/');
124129
$request->attributes->set('_controller', $controller);

0 commit comments

Comments
 (0)