[VarDumper] LinkStub fix

Author: nicolas-grekas

src/Symfony/Component/VarDumper/Caster/LinkStub.php

@@ -27,6 +27,9 @@ public function __construct($label, $line = 0, $href = null)
         }
         if (is_string($href)) {
             if (0 === strpos($href, 'file://')) {
+                if ($href === $label) {
+                    $label = substr($label, 7);
+                }
                 $href = substr($href, 7);
             } elseif (false !== strpos($href, '://')) {
                 $this->attr['href'] = $href;
@@ -39,7 +42,7 @@ public function __construct($label, $line = 0, $href = null)
                 }
                 $this->attr['file'] = realpath($href);
 
-                if ($this->attr['file'] === $href && 3 < count($ellipsis = explode(DIRECTORY_SEPARATOR, $href))) {
+                if ($this->attr['file'] === $label && 3 < count($ellipsis = explode(DIRECTORY_SEPARATOR, $href))) {
                     $this->attr['ellipsis'] = 2 + strlen(implode(array_slice($ellipsis, -2)));
                 }
             }

src/Symfony/Component/VarDumper/Tests/Caster/ExceptionCasterTest.php

@@ -139,15 +139,12 @@ public function testHtmlDump()
         $e = $this->getTestException(1);
         ExceptionCaster::$srcContext = -1;
 
-        $h = fopen('php://memory', 'r+b');
         $cloner = new VarCloner();
         $cloner->setMaxItems(1);
-        $dumper = new HtmlDumper($h);
+        $dumper = new HtmlDumper();
         $dumper->setDumpHeader('<foo></foo>');
         $dumper->setDumpBoundaries('<bar>', '</bar>');
-        $dumper->dump($cloner->cloneVar($e)->withRefHandles(false));
-        $dump = stream_get_contents($h, -1, 0);
-        fclose($h);
+        $dump = $dumper->dump($cloner->cloneVar($e)->withRefHandles(false), true);
 
         $expectedDump = <<<'EODUMP'
 <foo></foo><bar><span class=sf-dump-note>Exception</span> {<samp>

src/Symfony/Component/VarDumper/Tests/Caster/StubCasterTest.php

@@ -13,6 +13,7 @@
 
 use Symfony\Component\VarDumper\Caster\ArgsStub;
 use Symfony\Component\VarDumper\Caster\ClassStub;
+use Symfony\Component\VarDumper\Caster\LinkStub;
 use Symfony\Component\VarDumper\Cloner\VarCloner;
 use Symfony\Component\VarDumper\Dumper\HtmlDumper;
 use Symfony\Component\VarDumper\Test\VarDumperTestTrait;
@@ -85,6 +86,26 @@ public function testArgsStubWithClosure()
         $this->assertDumpMatchesFormat($expectedDump, $args);
     }
 
+    public function testLinkStub()
+    {
+        $var = array(new LinkStub(__CLASS__, 0, __FILE__));
+
+        $cloner = new VarCloner();
+        $dumper = new HtmlDumper();
+        $dumper->setDumpHeader('<foo></foo>');
+        $dumper->setDumpBoundaries('<bar>', '</bar>');
+        $dump = $dumper->dump($cloner->cloneVar($var), true);
+
+        $expectedDump = <<<'EODUMP'
+<foo></foo><bar><span class=sf-dump-note>array:1</span> [<samp>
+  <span class=sf-dump-index>0</span> => "<a data-file="%sStubCasterTest.php" data-line="1"><span class=sf-dump-str title="%d characters">Symfony\Component\VarDumper\Tests\Caster\StubCasterTest</span></a>"
+</samp>]
+</bar>
+EODUMP;
+
+        $this->assertStringMatchesFormat($expectedDump, $dump);
+    }
+
     public function testClassStub()
     {
         $var = array(new ClassStub('hello', array(FooInterface::class, 'foo')));