Skip to content

Commit bc40ad3

Browse files
Merge branch '4.4' into 5.4
* 4.4: [DoctrineBridge] Treat firstResult === 0 like null [HttpKernel] Fix SessionListener without session in request #46268
2 parents 9f02809 + 473f4dd commit bc40ad3

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

EventListener/AbstractSessionListener.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ public function onKernelResponse(ResponseEvent $event)
104104
// Always remove the internal header if present
105105
$response->headers->remove(self::NO_AUTO_CACHE_CONTROL_HEADER);
106106

107-
if (!$session = $this->container && $this->container->has('initialized_session') ? $this->container->get('initialized_session') : $event->getRequest()->getSession()) {
107+
if (!$session = $this->container && $this->container->has('initialized_session') ? $this->container->get('initialized_session') : ($event->getRequest()->hasSession() ? $event->getRequest()->getSession() : null)) {
108108
return;
109109
}
110110

Tests/EventListener/ResponseListenerTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ public function testSetContentLanguageHeaderWhenEmptyAndAtLeast2EnabledLocalesAr
102102
$request = Request::create('/');
103103
$request->setLocale('fr');
104104

105-
$event = new ResponseEvent($this->kernel, $request, HttpKernelInterface::MASTER_REQUEST, $response);
105+
$event = new ResponseEvent($this->kernel, $request, HttpKernelInterface::MAIN_REQUEST, $response);
106106
$this->dispatcher->dispatch($event, KernelEvents::RESPONSE);
107107

108108
$this->assertEquals('fr', $response->headers->get('Content-Language'));
@@ -118,7 +118,7 @@ public function testNotOverrideContentLanguageHeaderWhenNotEmpty()
118118
$request = Request::create('/');
119119
$request->setLocale('de');
120120

121-
$event = new ResponseEvent($this->kernel, $request, HttpKernelInterface::MASTER_REQUEST, $response);
121+
$event = new ResponseEvent($this->kernel, $request, HttpKernelInterface::MAIN_REQUEST, $response);
122122
$this->dispatcher->dispatch($event, KernelEvents::RESPONSE);
123123

124124
$this->assertEquals('mi, en', $response->headers->get('Content-Language'));
@@ -133,7 +133,7 @@ public function testNotSetContentLanguageHeaderWhenDisabled()
133133
$request = Request::create('/');
134134
$request->setLocale('fr');
135135

136-
$event = new ResponseEvent($this->kernel, $request, HttpKernelInterface::MASTER_REQUEST, $response);
136+
$event = new ResponseEvent($this->kernel, $request, HttpKernelInterface::MAIN_REQUEST, $response);
137137
$this->dispatcher->dispatch($event, KernelEvents::RESPONSE);
138138

139139
$this->assertNull($response->headers->get('Content-Language'));

Tests/EventListener/SessionListenerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -523,7 +523,7 @@ public function testUninitializedSessionWithoutInitializedSession()
523523
$container = new ServiceLocator([]);
524524

525525
$listener = new SessionListener($container);
526-
$listener->onKernelResponse(new ResponseEvent($kernel, new Request(), HttpKernelInterface::MASTER_REQUEST, $response));
526+
$listener->onKernelResponse(new ResponseEvent($kernel, new Request(), HttpKernelInterface::MAIN_REQUEST, $response));
527527
$this->assertFalse($response->headers->has('Expires'));
528528
$this->assertTrue($response->headers->hasCacheControlDirective('public'));
529529
$this->assertFalse($response->headers->hasCacheControlDirective('private'));

0 commit comments

Comments
 (0)