Skip to content

Commit 520b637

Browse files
committed
minor #32924 [cs-fixer] Use PhpUnit native assertions in filsystem checks (jderusse)
This PR was merged into the 3.4 branch. Discussion ---------- [cs-fixer] Use PhpUnit native assertions in filsystem checks | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | NA | License | MIT | Doc PR | NA This PR change the minimal value of PhpUnit introduced in #32885 in branche 3.4. Note: `5.6` is the highest value at the time. Commits ------- 226bdd18fb Use PHPunit assertion
2 parents 851501d + 95eb910 commit 520b637

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

Tests/IntlTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ public function testGetIcuStubVersionReadsTheVersionOfBundledStubs()
6161

6262
public function testGetDataDirectoryReturnsThePathToIcuData()
6363
{
64-
$this->assertTrue(is_dir(Intl::getDataDirectory()));
64+
$this->assertDirectoryExists(Intl::getDataDirectory());
6565
}
6666

6767
/**

Tests/Util/GitRepositoryTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public function testItClonesTheRepository()
5151
$git = GitRepository::download(self::REPO_URL, $this->targetDir);
5252

5353
$this->assertInstanceOf(GitRepository::class, $git);
54-
$this->assertTrue(is_dir($this->targetDir.'/.git'));
54+
$this->assertDirectoryExists($this->targetDir.'/.git');
5555
$this->assertSame($this->targetDir, $git->getPath());
5656
$this->assertSame(self::REPO_URL, $git->getUrl());
5757
$this->assertRegExp('#^[0-9a-z]{40}$#', $git->getLastCommitHash());

0 commit comments

Comments
 (0)