Skip to content

Commit 81718ad

Browse files
committed
Merge branch '3.4' into 4.4
* 3.4: Add missing dots at the end of exception messages
2 parents 528dbd3 + f39aee3 commit 81718ad

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

Data/Bundle/Compiler/GenrbCompiler.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public function __construct(string $genrb = 'genrb', string $envVars = '')
3737
exec('which '.$genrb, $output, $status);
3838

3939
if (0 !== $status) {
40-
throw new RuntimeException(sprintf('The command "%s" is not installed', $genrb));
40+
throw new RuntimeException(sprintf('The command "%s" is not installed.', $genrb));
4141
}
4242

4343
$this->genrb = ($envVars ? $envVars.' ' : '').$genrb;

Data/Bundle/Reader/JsonBundleReader.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public function read($path, $locale)
4646
$data = json_decode(file_get_contents($fileName), true);
4747

4848
if (null === $data) {
49-
throw new RuntimeException(sprintf('The resource bundle "%s" contains invalid JSON: %s', $fileName, json_last_error_msg()));
49+
throw new RuntimeException(sprintf('The resource bundle "%s" contains invalid JSON: %s.', $fileName, json_last_error_msg()));
5050
}
5151

5252
return $data;

DateFormatter/DateFormat/FullTransformer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ private function formatReplace(string $dateChars, \DateTime $dateTime): string
104104

105105
// handle unimplemented characters
106106
if (false !== strpos($this->notImplementedChars, $dateChars[0])) {
107-
throw new NotImplementedException(sprintf('Unimplemented date character "%s" in format "%s"', $dateChars[0], $this->pattern));
107+
throw new NotImplementedException(sprintf('Unimplemented date character "%s" in format "%s".', $dateChars[0], $this->pattern));
108108
}
109109

110110
return '';

Globals/IntlGlobals.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ public static function getErrorName(int $code): string
108108
public static function setError(int $code, string $message = '')
109109
{
110110
if (!isset(self::$errorCodes[$code])) {
111-
throw new \InvalidArgumentException(sprintf('No such error code: "%s"', $code));
111+
throw new \InvalidArgumentException(sprintf('No such error code: "%s".', $code));
112112
}
113113

114114
self::$errorMessage = $message ? sprintf('%s: %s', $message, self::$errorCodes[$code]) : self::$errorCodes[$code];

NumberFormatter/NumberFormatter.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,7 @@ public function format($value, $type = self::TYPE_DEFAULT)
363363
}
364364

365365
if (self::CURRENCY === $this->style) {
366-
throw new NotImplementedException(sprintf('%s() method does not support the formatting of currencies (instance with CURRENCY style). %s', __METHOD__, NotImplementedException::INTL_INSTALL_MESSAGE));
366+
throw new NotImplementedException(sprintf('%s() method does not support the formatting of currencies (instance with CURRENCY style). %s.', __METHOD__, NotImplementedException::INTL_INSTALL_MESSAGE));
367367
}
368368

369369
// Only the default type is supported.

0 commit comments

Comments
 (0)