Skip to content

Commit ad84190

Browse files
committed
Merge branch '5.4' into 6.4
* 5.4: Mutate remaining data providers to static ones
2 parents c766246 + e4171a0 commit ad84190

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

Tests/LocalesTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,12 @@ class LocalesTest extends ResourceBundleTestCase
2121
{
2222
public function testGetLocales()
2323
{
24-
$this->assertSame($this->getLocales(), Locales::getLocales());
24+
$this->assertSame(static::getLocales(), Locales::getLocales());
2525
}
2626

2727
public function testGetAliases()
2828
{
29-
$this->assertSame($this->getLocaleAliases(), Locales::getAliases());
29+
$this->assertSame(static::getLocaleAliases(), Locales::getAliases());
3030
}
3131

3232
/**
@@ -41,7 +41,7 @@ public function testGetNames($displayLocale)
4141
// We can't assert on exact list of locale, as there's too many variations.
4242
// The best we can do is to make sure getNames() returns a subset of what getLocales() returns.
4343
$this->assertNotEmpty($locales);
44-
$this->assertEmpty(array_diff($locales, $this->getLocales()));
44+
$this->assertEmpty(array_diff($locales, static::getLocales()));
4545
}
4646

4747
public function testGetNamesDefaultLocale()

Tests/ResourceBundleTestCase.php

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -758,45 +758,45 @@ protected function tearDown(): void
758758
\Locale::setDefault($this->defaultLocale);
759759
}
760760

761-
public function provideLocales()
761+
public static function provideLocales()
762762
{
763763
return array_map(
764764
fn ($locale) => [$locale],
765-
$this->getLocales()
765+
static::getLocales()
766766
);
767767
}
768768

769-
public function provideLocaleAliases()
769+
public static function provideLocaleAliases()
770770
{
771771
return array_map(
772772
fn ($alias, $ofLocale) => [$alias, $ofLocale],
773-
array_keys($this->getLocaleAliases()),
774-
$this->getLocaleAliases()
773+
array_keys(static::getLocaleAliases()),
774+
static::getLocaleAliases()
775775
);
776776
}
777777

778-
public function provideRootLocales()
778+
public static function provideRootLocales()
779779
{
780780
return array_map(
781781
fn ($locale) => [$locale],
782782
$this->getRootLocales()
783783
);
784784
}
785785

786-
protected function getLocales()
786+
protected static function getLocales()
787787
{
788788
return self::LOCALES;
789789
}
790790

791-
protected function getLocaleAliases()
791+
protected static function getLocaleAliases()
792792
{
793793
return self::LOCALE_ALIASES;
794794
}
795795

796-
protected function getRootLocales()
796+
protected static function getRootLocales()
797797
{
798798
if (null === self::$rootLocales) {
799-
self::$rootLocales = array_filter($this->getLocales(), fn ($locale) => // no locales for which fallback is possible (e.g "en_GB")
799+
self::$rootLocales = array_filter(static::getLocales(), fn ($locale) => // no locales for which fallback is possible (e.g "en_GB")
800800
!str_contains($locale, '_'));
801801
}
802802

0 commit comments

Comments
 (0)