Use typed properties in tests as much as possible

Author: nicolas-grekas

Tests/Data/Bundle/Reader/BundleEntryReaderTest.php

@@ -25,15 +25,8 @@ class BundleEntryReaderTest extends TestCase
 {
     private const RES_DIR = '/res/dir';
 
-    /**
-     * @var BundleEntryReader
-     */
-    private $reader;
-
-    /**
-     * @var MockObject&BundleEntryReaderInterface
-     */
-    private $readerImpl;
+    private BundleEntryReader $reader;
+    private MockObject&BundleEntryReaderInterface $readerImpl;
 
     private const DATA = [
         'Entries' => [

Tests/Data/Bundle/Reader/IntlBundleReaderTest.php

@@ -23,10 +23,7 @@
  */
 class IntlBundleReaderTest extends TestCase
 {
-    /**
-     * @var IntlBundleReader
-     */
-    private $reader;
+    private IntlBundleReader $reader;
 
     protected function setUp(): void
     {

Tests/Data/Bundle/Reader/JsonBundleReaderTest.php

@@ -21,10 +21,7 @@
  */
 class JsonBundleReaderTest extends TestCase
 {
-    /**
-     * @var JsonBundleReader
-     */
-    private $reader;
+    private JsonBundleReader $reader;
 
     protected function setUp(): void
     {

Tests/Data/Bundle/Reader/PhpBundleReaderTest.php

@@ -21,10 +21,7 @@
  */
 class PhpBundleReaderTest extends TestCase
 {
-    /**
-     * @var PhpBundleReader
-     */
-    private $reader;
+    private PhpBundleReader $reader;
 
     protected function setUp(): void
     {

Tests/Data/Bundle/Writer/JsonBundleWriterTest.php

@@ -20,17 +20,9 @@
  */
 class JsonBundleWriterTest extends TestCase
 {
-    /**
-     * @var JsonBundleWriter
-     */
-    private $writer;
-
-    private $directory;
-
-    /**
-     * @var Filesystem
-     */
-    private $filesystem;
+    private JsonBundleWriter $writer;
+    private string $directory;
+    private Filesystem $filesystem;
 
     protected function setUp(): void
     {

Tests/Data/Bundle/Writer/PhpBundleWriterTest.php

@@ -20,17 +20,9 @@
  */
 class PhpBundleWriterTest extends TestCase
 {
-    /**
-     * @var PhpBundleWriter
-     */
-    private $writer;
-
-    private $directory;
-
-    /**
-     * @var Filesystem
-     */
-    private $filesystem;
+    private PhpBundleWriter $writer;
+    private string $directory;
+    private Filesystem $filesystem;
 
     protected function setUp(): void
     {

Tests/Data/Bundle/Writer/TextBundleWriterTest.php

@@ -22,17 +22,9 @@
  */
 class TextBundleWriterTest extends TestCase
 {
-    /**
-     * @var TextBundleWriter
-     */
-    private $writer;
-
-    private $directory;
-
-    /**
-     * @var Filesystem
-     */
-    private $filesystem;
+    private TextBundleWriter $writer;
+    private string $directory;
+    private Filesystem $filesystem;
 
     protected function setUp(): void
     {

Tests/Data/Util/LocaleScannerTest.php

@@ -20,17 +20,9 @@
  */
 class LocaleScannerTest extends TestCase
 {
-    private $directory;
-
-    /**
-     * @var Filesystem
-     */
-    private $filesystem;
-
-    /**
-     * @var LocaleScanner
-     */
-    private $scanner;
+    private string $directory;
+    private Filesystem $filesystem;
+    private LocaleScanner $scanner;
 
     protected function setUp(): void
     {

Tests/Data/Util/RingBufferTest.php

@@ -20,10 +20,7 @@
  */
 class RingBufferTest extends TestCase
 {
-    /**
-     * @var RingBuffer
-     */
-    private $buffer;
+    private RingBuffer $buffer;
 
     protected function setUp(): void
     {

Tests/IntlTest.php

@@ -16,7 +16,7 @@
 
 class IntlTest extends TestCase
 {
-    private $defaultLocale;
+    private string $defaultLocale;
 
     protected function setUp(): void
     {

Tests/ResourceBundleTestCase.php

@@ -734,8 +734,8 @@ abstract class ResourceBundleTestCase extends TestCase
         'zh_TW' => 'zh_Hant_TW',
     ];
 
-    private static $rootLocales;
-    private $defaultLocale;
+    private static ?array $rootLocales = null;
+    private string $defaultLocale;
 
     protected function setUp(): void
     {

Tests/ScriptsTest.php

@@ -21,7 +21,7 @@ class ScriptsTest extends ResourceBundleTestCase
 {
     // The below arrays document the state of the ICU data bundled with this package.
 
-    protected static $scripts = [
+    protected static array $scripts = [
         'Adlm',
         'Afak',
         'Aghb',

Tests/Util/GitRepositoryTest.php

@@ -21,7 +21,7 @@
  */
 class GitRepositoryTest extends TestCase
 {
-    private $targetDir;
+    private ?string $targetDir = null;
 
     private const REPO_URL = 'https://github.com/symfony/intl.git';