Merge branch '4.4' into 5.1

* 4.4:
  Enable "native_constant_invocation" CS rule
  Make AbstractPhpFileCacheWarmer public

Author: nicolas-grekas

Collator/Collator.php

@@ -109,9 +109,9 @@ public static function create(?string $locale)
     public function asort(array &$array, int $sortFlag = self::SORT_REGULAR)
     {
         $intlToPlainFlagMap = [
-            self::SORT_REGULAR => SORT_REGULAR,
-            self::SORT_NUMERIC => SORT_NUMERIC,
-            self::SORT_STRING => SORT_STRING,
+            self::SORT_REGULAR => \SORT_REGULAR,
+            self::SORT_NUMERIC => \SORT_NUMERIC,
+            self::SORT_STRING => \SORT_STRING,
         ];
 
         $plainSortFlag = isset($intlToPlainFlagMap[$sortFlag]) ? $intlToPlainFlagMap[$sortFlag] : self::SORT_REGULAR;

Data/Bundle/Writer/JsonBundleWriter.php

@@ -35,7 +35,7 @@ public function write(string $path, string $locale, $data)
             }
         });
 
-        $contents = json_encode($data, JSON_PRETTY_PRINT | JSON_UNESCAPED_UNICODE)."\n";
+        $contents = json_encode($data, \JSON_PRETTY_PRINT | \JSON_UNESCAPED_UNICODE)."\n";
 
         file_put_contents($path.'/'.$locale.'.json', $contents);
     }

Data/Generator/LocaleDataGenerator.php

@@ -67,7 +67,7 @@ protected function preGenerate()
         // Write parents locale file for the Translation component
         file_put_contents(
             __DIR__.'/../../../Translation/Resources/data/parents.json',
-            json_encode($this->localeParents, JSON_PRETTY_PRINT).PHP_EOL
+            json_encode($this->localeParents, \JSON_PRETTY_PRINT).\PHP_EOL
         );
     }
 

Data/Util/LocaleScanner.php

@@ -40,7 +40,7 @@ class LocaleScanner
      */
     public function scanLocales(string $sourceDir): array
     {
-        $locales = glob($sourceDir.'/*.txt', GLOB_NOSORT);
+        $locales = glob($sourceDir.'/*.txt', \GLOB_NOSORT);
 
         // Remove file extension and sort
         array_walk($locales, function (&$locale) { $locale = basename($locale, '.txt'); });

DateFormatter/DateFormat/Transformer.php

@@ -60,6 +60,6 @@ abstract public function extractDateOptions(string $matched, int $length): array
      */
     protected function padLeft(string $value, int $length): string
     {
-        return str_pad($value, $length, '0', STR_PAD_LEFT);
+        return str_pad($value, $length, '0', \STR_PAD_LEFT);
     }
 }

Intl.php

@@ -85,7 +85,7 @@ public static function getIcuVersion(): ?string
             if (!self::isExtensionLoaded()) {
                 self::$icuVersion = self::getIcuStubVersion();
             } elseif (\defined('INTL_ICU_VERSION')) {
-                self::$icuVersion = INTL_ICU_VERSION;
+                self::$icuVersion = \INTL_ICU_VERSION;
             } else {
                 try {
                     $reflector = new \ReflectionExtension('intl');

NumberFormatter/NumberFormatter.php

@@ -201,9 +201,9 @@ abstract class NumberFormatter
      * @see https://php.net/round
      */
     private static $phpRoundingMap = [
-        self::ROUND_HALFDOWN => PHP_ROUND_HALF_DOWN,
-        self::ROUND_HALFEVEN => PHP_ROUND_HALF_EVEN,
-        self::ROUND_HALFUP => PHP_ROUND_HALF_UP,
+        self::ROUND_HALFDOWN => \PHP_ROUND_HALF_DOWN,
+        self::ROUND_HALFEVEN => \PHP_ROUND_HALF_EVEN,
+        self::ROUND_HALFUP => \PHP_ROUND_HALF_UP,
     ];
 
     /**
@@ -354,7 +354,7 @@ public function format($value, int $type = self::TYPE_DEFAULT)
     {
         // The original NumberFormatter does not support this format type
         if (self::TYPE_CURRENCY === $type) {
-            trigger_error(__METHOD__.'(): Unsupported format type '.$type, E_USER_WARNING);
+            trigger_error(__METHOD__.'(): Unsupported format type '.$type, \E_USER_WARNING);
 
             return false;
         }
@@ -508,7 +508,7 @@ public function parseCurrency(string $value, string &$currency, int &$position =
     public function parse(string $value, int $type = self::TYPE_DOUBLE, int &$position = 0)
     {
         if (self::TYPE_DEFAULT === $type || self::TYPE_CURRENCY === $type) {
-            trigger_error(__METHOD__.'(): Unsupported format type '.$type, E_USER_WARNING);
+            trigger_error(__METHOD__.'(): Unsupported format type '.$type, \E_USER_WARNING);
 
             return false;
         }

Resources/bin/common.php

@@ -68,7 +68,7 @@ function get_icu_version_from_genrb($genrb)
     return $matches[1];
 }
 
-error_reporting(E_ALL);
+error_reporting(\E_ALL);
 
 set_error_handler(function ($type, $msg, $file, $line) {
     throw new \ErrorException($msg, 0, $type, $file, $line);