Merge branch '5.4' into 6.0

* 5.4:
  [VarExporter] fix tests on Windows
  [GHA] Fix psalm job
  Fix CS
  [PropertyInfo] strip only leading `\` when unknown docType
  [RateLimiter] Fix rate serialization for long intervals (monthly and yearly)
  ignoring exception from sem_get in SemaphoreStore Lock component, preventing of error: identifier removed
  [Console] Fix compact table style to avoid outputting a leading space
  fix: stringify from address for ses+api transport
  [Mailer] Use recipients in sendmail transport
  [Serializer] Fix nested deserialization_path computation when there is no metadata for the attribute
  [Asset] Update the error message when assets are not built

Author: nicolas-grekas

Tests/Transport/Fixtures/fake-sendmail.php

@@ -0,0 +1,5 @@
+#!/usr/bin/env php
+<?php
+$argsPath = sys_get_temp_dir().\DIRECTORY_SEPARATOR.'sendmail_args';
+
+file_put_contents($argsPath, implode(' ', $argv));

Tests/Transport/SendmailTransportTest.php

@@ -12,13 +12,81 @@
 namespace Symfony\Component\Mailer\Tests\Transport;
 
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\Mailer\DelayedEnvelope;
 use Symfony\Component\Mailer\Transport\SendmailTransport;
+use Symfony\Component\Mime\Address;
+use Symfony\Component\Mime\Email;
 
 class SendmailTransportTest extends TestCase
 {
+    private const FAKE_SENDMAIL = __DIR__.'/Fixtures/fake-sendmail.php -t';
+
+    /**
+     * @var string
+     */
+    private $argsPath;
+
+    protected function setUp(): void
+    {
+        $this->argsPath = sys_get_temp_dir().\DIRECTORY_SEPARATOR.'sendmail_args';
+    }
+
+    protected function tearDown(): void
+    {
+        if (file_exists($this->argsPath)) {
+            @unlink($this->argsPath);
+        }
+        unset($this->argsPath);
+    }
+
     public function testToString()
     {
         $t = new SendmailTransport();
         $this->assertEquals('smtp://sendmail', (string) $t);
     }
+
+    public function testToIsUsedWhenRecipientsAreNotSet()
+    {
+        if ('\\' === \DIRECTORY_SEPARATOR) {
+            $this->markTestSkipped('Windows does not support shebangs nor non-blocking standard streams');
+        }
+
+        $mail = new Email();
+        $mail
+            ->from('[email protected]')
+            ->to('[email protected]')
+            ->subject('Subject')
+            ->text('Some text')
+        ;
+
+        $envelope = new DelayedEnvelope($mail);
+
+        $sendmailTransport = new SendmailTransport(self::FAKE_SENDMAIL);
+        $sendmailTransport->send($mail, $envelope);
+
+        $this->assertStringEqualsFile($this->argsPath, __DIR__.'/Fixtures/fake-sendmail.php [email protected] [email protected]');
+    }
+
+    public function testRecipientsAreUsedWhenSet()
+    {
+        if ('\\' === \DIRECTORY_SEPARATOR) {
+            $this->markTestSkipped('Windows does not support shebangs nor non-blocking standard streams');
+        }
+
+        $mail = new Email();
+        $mail
+            ->from('[email protected]')
+            ->to('[email protected]')
+            ->subject('Subject')
+            ->text('Some text')
+        ;
+
+        $envelope = new DelayedEnvelope($mail);
+        $envelope->setRecipients([new Address('[email protected]')]);
+
+        $sendmailTransport = new SendmailTransport(self::FAKE_SENDMAIL);
+        $sendmailTransport->send($mail, $envelope);
+
+        $this->assertStringEqualsFile($this->argsPath, __DIR__.'/Fixtures/fake-sendmail.php [email protected] [email protected]');
+    }
 }

Transport/SendmailTransport.php

@@ -91,6 +91,11 @@ protected function doSend(SentMessage $message): void
         $this->getLogger()->debug(sprintf('Email transport "%s" starting', __CLASS__));
 
         $command = $this->command;
+
+        if ($recipients = $message->getEnvelope()->getRecipients()) {
+            $command = str_replace(' -t', '', $command);
+        }
+
         if (!str_contains($command, ' -f')) {
             $command .= ' -f'.escapeshellarg($message->getEnvelope()->getSender()->getEncodedAddress());
         }
@@ -101,6 +106,10 @@ protected function doSend(SentMessage $message): void
             $chunks = AbstractStream::replace("\n.", "\n..", $chunks);
         }
 
+        foreach ($recipients as $recipient) {
+            $command .= ' '.escapeshellarg($recipient->getEncodedAddress());
+        }
+
         $this->stream->setCommand($command);
         $this->stream->initialize();
         foreach ($chunks as $chunk) {