Skip to content

Commit aa23e05

Browse files
OskarStarknicolas-grekas
authored andcommitted
[Mailer] [Bridges] Use CPP and add more #[\SensitiveParameter] attributes
1 parent 3c1dea6 commit aa23e05

File tree

2 files changed

+16
-20
lines changed

2 files changed

+16
-20
lines changed

Transport/MailgunApiTransport.php

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -33,16 +33,14 @@ class MailgunApiTransport extends AbstractApiTransport
3333
{
3434
private const HOST = 'api.%region_dot%mailgun.net';
3535

36-
private string $key;
37-
private string $domain;
38-
private ?string $region;
39-
40-
public function __construct(string $key, string $domain, string $region = null, HttpClientInterface $client = null, EventDispatcherInterface $dispatcher = null, LoggerInterface $logger = null)
41-
{
42-
$this->key = $key;
43-
$this->domain = $domain;
44-
$this->region = $region;
45-
36+
public function __construct(
37+
#[\SensitiveParameter] private string $key,
38+
private string $domain,
39+
private ?string $region = null,
40+
HttpClientInterface $client = null,
41+
EventDispatcherInterface $dispatcher = null,
42+
LoggerInterface $logger = null,
43+
) {
4644
parent::__construct($client, $dispatcher, $logger);
4745
}
4846

Transport/MailgunHttpTransport.php

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -32,16 +32,14 @@ class MailgunHttpTransport extends AbstractHttpTransport
3232

3333
private const HOST = 'api.%region_dot%mailgun.net';
3434

35-
private string $key;
36-
private string $domain;
37-
private ?string $region;
38-
39-
public function __construct(string $key, string $domain, string $region = null, HttpClientInterface $client = null, EventDispatcherInterface $dispatcher = null, LoggerInterface $logger = null)
40-
{
41-
$this->key = $key;
42-
$this->domain = $domain;
43-
$this->region = $region;
44-
35+
public function __construct(
36+
#[\SensitiveParameter] private string $key,
37+
private string $domain,
38+
private ?string $region = null,
39+
HttpClientInterface $client = null,
40+
EventDispatcherInterface $dispatcher = null,
41+
LoggerInterface $logger = null,
42+
) {
4543
parent::__construct($client, $dispatcher, $logger);
4644
}
4745

0 commit comments

Comments
 (0)