Try to fix tests

Author: welcoMattic

src/Maker/MakeController.php

@@ -39,7 +39,7 @@ public function configureCommand(Command $command, InputConfiguration $inputConf
         $command
             ->setDescription('Creates a new controller class')
             ->addArgument('controller-class', InputArgument::OPTIONAL, sprintf('Choose a name for your controller class (e.g. <fg=yellow>%sController</>)', Str::asClassName(Str::getRandomTerm())))
-            ->addOption('--no-template', '-n', InputOption::VALUE_OPTIONAL)
+            ->addOption('no-template', 'n', InputOption::VALUE_NONE, 'Use this option to disable template generation')
             ->setHelp(file_get_contents(__DIR__.'/../Resources/help/MakeController.txt'))
         ;
     }
@@ -52,20 +52,20 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
             'Controller'
         );
 
-        $withTemplate = !$input->getOption('--no-template');
+        $noTemplate = $input->getOption('no-template');
         $templateName = Str::asFilePath($controllerClassNameDetails->getRelativeNameWithoutSuffix()).'/index.html.twig';
         $controllerPath = $generator->generateController(
             $controllerClassNameDetails->getFullName(),
             'controller/Controller.tpl.php',
             [
                 'route_path' => Str::asRoutePath($controllerClassNameDetails->getRelativeNameWithoutSuffix()),
                 'route_name' => Str::asRouteName($controllerClassNameDetails->getRelativeNameWithoutSuffix()),
-                'twig_installed' => $this->isTwigInstalled() && $withTemplate,
+                'with_template' => $this->isTwigInstalled() && !$noTemplate,
                 'template_name' => $templateName,
             ]
         );
 
-        if ($this->isTwigInstalled() && $withTemplate) {
+        if ($this->isTwigInstalled() && !$noTemplate) {
             $generator->generateFile(
                 'templates/'.$templateName,
                 'controller/twig_template.tpl.php',

src/Resources/help/MakeController.txt

@@ -3,3 +3,7 @@ The <info>%command.name%</info> command generates a new controller class.
 <info>php %command.full_name% CoolStuffController</info>
 
 If the argument is missing, the command will ask for the controller class name interactively.
+
+You can also generate the controller alone, without template with this option:
+
+<info>php %command.full_name% --no-template</info>

src/Resources/skeleton/controller/Controller.tpl.php

@@ -12,7 +12,7 @@ class <?= $class_name; ?> extends <?= $parent_class_name; ?><?= "\n" ?>
      */
     public function index()
     {
-<?php if ($twig_installed) { ?>
+<?php if ($with_template) { ?>
         return $this->render('<?= $template_name ?>', [
             'controller_name' => '<?= $class_name ?>',
         ]);

tests/Maker/FunctionalTest.php

@@ -125,15 +125,16 @@ public function getCommandTests()
             $this->getMakerInstance(MakeController::class),
             [
                 // controller class name
-                'FooTwig',
+                'FooNoTemplate',
                 // option to disable template generation
                 '--no-template'
             ])
-            ->setFixtureFilesPath(__DIR__.'/../fixtures/MakeController')
             ->addExtraDependencies('twig')
             ->assert(function (string $output, string $directory) {
                 // make sure the template was not configured
                 $this->assertContainsCount('created: ', $output, 1);
+                $this->assertContains('created: src/Controller/FooNoTemplateController.php', $output);
+                $this->assertNotContains('created: templates/foo_no_template/index.html.twig', $output);
             })
         ];