methods are always fluent

Author: jrushlow

src/Maker/MakeEntity.php

@@ -807,7 +807,6 @@ private function createClassManipulator(string $path, ConsoleStyle $io, bool $ov
         $manipulator = new ClassSourceManipulator(
             sourceCode: $this->fileManager->getFileContents($path),
             overwrite: $overwrite,
-            fluentMutators: true,
             useAttributesForDoctrineMapping: true
         );
 

src/Maker/MakeRegistrationForm.php

@@ -392,7 +392,6 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
             $userManipulator = new ClassSourceManipulator(
                 sourceCode: file_get_contents($classDetails->getPath()),
                 overwrite: false,
-                fluentMutators: true,
                 useAttributesForDoctrineMapping: true
             );
             $userManipulator->setIo($io);

src/Maker/MakeResetPassword.php

@@ -406,7 +406,6 @@ private function generateRequestEntity(Generator $generator, ClassNameDetails $r
         $manipulator = new ClassSourceManipulator(
             sourceCode: $this->fileManager->getFileContents($requestEntityPath),
             overwrite: false,
-            fluentMutators: true,
             useAttributesForDoctrineMapping: $useAttributesForDoctrineMapping
         );
 

src/Maker/MakeUser.php

@@ -150,7 +150,6 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
         $manipulator = new ClassSourceManipulator(
             sourceCode: $this->fileManager->getFileContents($classPath),
             overwrite: true,
-            fluentMutators: true,
             useAttributesForDoctrineMapping: $useAttributesForDoctrineMapping
         );
 

src/Test/MakerTestRunner.php

@@ -256,7 +256,6 @@ public function manipulateClass(string $filename, \Closure $callback): void
         $manipulator = new ClassSourceManipulator(
             sourceCode: $contents,
             overwrite: true,
-            fluentMutators: true,
             useAttributesForDoctrineMapping: true
         );
         $callback($manipulator);

src/Util/ClassSourceManipulator.php

@@ -59,13 +59,8 @@ final class ClassSourceManipulator
     public function __construct(
         private string $sourceCode,
         private bool $overwrite = false,
-        private bool $fluentMutators = true,
         private bool $useAttributesForDoctrineMapping = true,
     ) {
-        if (false === $this->fluentMutators) {
-            trigger_deprecation('symfony/maker-bundle', '0.0.0', 'Why is this false.');
-        }
-
         $this->lexer = new Lexer\Emulative([
             'usedAttributes' => [
                 'comments',
@@ -1017,10 +1012,6 @@ private function addMethod(Node\Stmt\ClassMethod $methodNode): void
 
     private function makeMethodFluent(Builder\Method $methodBuilder): void
     {
-        if (!$this->fluentMutators) {
-            return;
-        }
-
         $methodBuilder
             ->addStmt($this->createBlankLineNode(self::CONTEXT_CLASS_METHOD))
             ->addStmt(new Node\Stmt\Return_(new Node\Expr\Variable('this')));

tests/Util/ClassSourceManipulatorTest.php

@@ -225,7 +225,7 @@ public function testAddEntityField(string $sourceFilename, string $propertyName,
 
     private function runAddEntityFieldTests(string $source, string $propertyName, array $fieldOptions, string $expected): void
     {
-        $manipulator = new ClassSourceManipulator($source, false, true, true);
+        $manipulator = new ClassSourceManipulator($source, false,true);
         $manipulator->addEntityField($propertyName, $fieldOptions);
 
         $this->assertSame($expected, $manipulator->getSourceCode());
@@ -304,7 +304,7 @@ public function testAddManyToOneRelation(string $sourceFilename, $expectedSource
 
     public function runAddManyToOneRelationTests(string $source, string $expected, RelationManyToOne $manyToOne): void
     {
-        $manipulator = new ClassSourceManipulator($source, false, true, true);
+        $manipulator = new ClassSourceManipulator($source, false, true);
         $manipulator->addManyToOneRelation($manyToOne);
 
         $this->assertSame($expected, $manipulator->getSourceCode());
@@ -402,7 +402,7 @@ public function testAddOneToManyRelation(string $sourceFilename, string $expecte
 
     private function runAddOneToManyRelationTests(string $source, string $expected, RelationOneToMany $oneToMany): void
     {
-        $manipulator = new ClassSourceManipulator($source, false, true, true);
+        $manipulator = new ClassSourceManipulator($source, false, true);
         $manipulator->addOneToManyRelation($oneToMany);
 
         $this->assertSame($expected, $manipulator->getSourceCode());
@@ -463,7 +463,7 @@ public function testAddManyToManyRelation(string $sourceFilename, $expectedSourc
 
     private function runAddManyToManyRelationTest(string $source, string $expected, RelationManyToMany $manyToMany): void
     {
-        $manipulator = new ClassSourceManipulator($source, false, true, true);
+        $manipulator = new ClassSourceManipulator($source, false, true);
         $manipulator->addManyToManyRelation($manyToMany);
 
         $this->assertSame($expected, $manipulator->getSourceCode());
@@ -522,7 +522,7 @@ public function testAddOneToOneRelation(string $sourceFilename, $expectedSourceF
 
     private function runAddOneToOneRelation(string $source, string $expected, RelationOneToOne $oneToOne): void
     {
-        $manipulator = new ClassSourceManipulator($source, false, true, true);
+        $manipulator = new ClassSourceManipulator($source, false, true);
         $manipulator->addOneToOneRelation($oneToOne);
 
         $this->assertSame($expected, $manipulator->getSourceCode());