Merge pull request #1154 from jrushlow/fix/empty-attribute

jrushlow · web-flow · commit 28319beb162f · 2022-07-21T15:30:02.000-04:00
[make:entity] remove empty parenthesis on `id`
diff --git a/src/Resources/skeleton/doctrine/Entity.tpl.php b/src/Resources/skeleton/doctrine/Entity.tpl.php
@@ -17,7 +17,7 @@ class <?= $class_name."\n" ?>
 {
     #[ORM\Id]
     #[ORM\GeneratedValue]
-    #[ORM\Column()]
+    #[ORM\Column]
     private ?int $id = null;
 
     public function getId(): ?int
diff --git a/tests/Doctrine/fixtures/expected_no_overwrite/src/Entity/BaseClient.php b/tests/Doctrine/fixtures/expected_no_overwrite/src/Entity/BaseClient.php
@@ -11,7 +11,7 @@ class BaseClient
 
     #[ORM\Id]
     #[ORM\GeneratedValue]
-    #[ORM\Column()]
+    #[ORM\Column]
     private ?int $id = null;
 
     #[ORM\Column]
diff --git a/tests/Doctrine/fixtures/expected_no_overwrite/src/Entity/Client.php b/tests/Doctrine/fixtures/expected_no_overwrite/src/Entity/Client.php
@@ -14,7 +14,7 @@ class Client extends BaseClient
     /**
      * @var string
      */
-    #[ORM\Column()]
+    #[ORM\Column]
     private ?string $apiKey = null;
 
     #[ORM\ManyToMany(targetEntity: Tag::class)]
diff --git a/tests/Doctrine/fixtures/expected_no_overwrite/src/Entity/Embed.php b/tests/Doctrine/fixtures/expected_no_overwrite/src/Entity/Embed.php
@@ -8,7 +8,7 @@
 #[ORM\Embeddable]
 class Embed
 {
-    #[ORM\Column()]
+    #[ORM\Column]
     private ?int $val = null;
 
     public function getVal(): ?int
diff --git a/tests/Doctrine/fixtures/expected_no_overwrite/src/Entity/Tag.php b/tests/Doctrine/fixtures/expected_no_overwrite/src/Entity/Tag.php
@@ -10,7 +10,7 @@ class Tag
 {
     #[ORM\Id]
     #[ORM\GeneratedValue]
-    #[ORM\Column()]
+    #[ORM\Column]
     private ?int $id = null;
 
     public function getId(): ?int
diff --git a/tests/Doctrine/fixtures/expected_no_overwrite/src/Entity/User.php b/tests/Doctrine/fixtures/expected_no_overwrite/src/Entity/User.php
@@ -11,7 +11,7 @@ class User
 {
     #[ORM\Id]
     #[ORM\GeneratedValue]
-    #[ORM\Column()]
+    #[ORM\Column]
     private ?int $id = null;
 
     #[ORM\OneToMany(targetEntity: UserAvatar::class, mappedBy: 'user')]
diff --git a/tests/Doctrine/fixtures/expected_no_overwrite/src/Entity/UserAvatar.php b/tests/Doctrine/fixtures/expected_no_overwrite/src/Entity/UserAvatar.php
@@ -9,7 +9,7 @@ class UserAvatar
 {
     #[ORM\Id]
     #[ORM\GeneratedValue]
-    #[ORM\Column()]
+    #[ORM\Column]
     private ?int $id = null;
 
     #[ORM\ManyToOne(inversedBy: 'avatars', cascade: ['persist', 'remove'])]
diff --git a/tests/Doctrine/fixtures/expected_no_overwrite/src/Entity/UserProfile.php b/tests/Doctrine/fixtures/expected_no_overwrite/src/Entity/UserProfile.php
@@ -10,7 +10,7 @@ class UserProfile
 {
     #[ORM\Id]
     #[ORM\GeneratedValue]
-    #[ORM\Column()]
+    #[ORM\Column]
     private ?int $id = null;
 
     #[ORM\OneToOne(inversedBy: 'userProfile', cascade: ['persist', 'remove'])]
diff --git a/tests/Doctrine/fixtures/expected_overwrite/src/Entity/BaseClient.php b/tests/Doctrine/fixtures/expected_overwrite/src/Entity/BaseClient.php
@@ -11,7 +11,7 @@ class BaseClient
 
     #[ORM\Id]
     #[ORM\GeneratedValue]
-    #[ORM\Column()]
+    #[ORM\Column]
     private ?int $id = null;
 
     #[ORM\Column]
diff --git a/tests/Doctrine/fixtures/expected_overwrite/src/Entity/Client.php b/tests/Doctrine/fixtures/expected_overwrite/src/Entity/Client.php
@@ -14,7 +14,7 @@ class Client extends BaseClient
     /**
      * @var string
      */
-    #[ORM\Column()]
+    #[ORM\Column]
     private ?string $apiKey = null;
 
     #[ORM\ManyToMany(targetEntity: Tag::class)]
diff --git a/tests/Doctrine/fixtures/expected_overwrite/src/Entity/Embed.php b/tests/Doctrine/fixtures/expected_overwrite/src/Entity/Embed.php
@@ -8,7 +8,7 @@
 #[ORM\Embeddable]
 class Embed
 {
-    #[ORM\Column()]
+    #[ORM\Column]
     private ?int $val = null;
 
     public function getVal(): ?int
diff --git a/tests/Doctrine/fixtures/expected_overwrite/src/Entity/Tag.php b/tests/Doctrine/fixtures/expected_overwrite/src/Entity/Tag.php
@@ -10,7 +10,7 @@ class Tag
 {
     #[ORM\Id]
     #[ORM\GeneratedValue]
-    #[ORM\Column()]
+    #[ORM\Column]
     private ?int $id = null;
 
     public function getId(): ?int
diff --git a/tests/Doctrine/fixtures/expected_overwrite/src/Entity/User.php b/tests/Doctrine/fixtures/expected_overwrite/src/Entity/User.php
@@ -11,7 +11,7 @@ class User
 {
     #[ORM\Id]
     #[ORM\GeneratedValue]
-    #[ORM\Column()]
+    #[ORM\Column]
     private ?int $id = null;
 
     #[ORM\OneToMany(targetEntity: UserAvatar::class, mappedBy: 'user')]
diff --git a/tests/Doctrine/fixtures/expected_overwrite/src/Entity/UserAvatar.php b/tests/Doctrine/fixtures/expected_overwrite/src/Entity/UserAvatar.php
@@ -9,7 +9,7 @@ class UserAvatar
 {
     #[ORM\Id]
     #[ORM\GeneratedValue]
-    #[ORM\Column()]
+    #[ORM\Column]
     private ?int $id = null;
 
     #[ORM\ManyToOne(inversedBy: 'avatars', cascade: ['persist', 'remove'])]
diff --git a/tests/Doctrine/fixtures/expected_overwrite/src/Entity/UserProfile.php b/tests/Doctrine/fixtures/expected_overwrite/src/Entity/UserProfile.php
@@ -10,7 +10,7 @@ class UserProfile
 {
     #[ORM\Id]
     #[ORM\GeneratedValue]
-    #[ORM\Column()]
+    #[ORM\Column]
     private ?int $id = null;
 
     #[ORM\OneToOne(inversedBy: 'userProfile', cascade: ['persist', 'remove'])]
diff --git a/tests/Doctrine/fixtures/source_project/src/Entity/BaseClient.php b/tests/Doctrine/fixtures/source_project/src/Entity/BaseClient.php
@@ -11,7 +11,7 @@ class BaseClient
 
     #[ORM\Id]
     #[ORM\GeneratedValue]
-    #[ORM\Column()]
+    #[ORM\Column]
     private ?int $id = null;
 
     #[ORM\Column]
diff --git a/tests/Doctrine/fixtures/source_project/src/Entity/Client.php b/tests/Doctrine/fixtures/source_project/src/Entity/Client.php
@@ -13,7 +13,7 @@ class Client extends BaseClient
     /**
      * @var string
      */
-    #[ORM\Column()]
+    #[ORM\Column]
     private ?string $apiKey = null;
 
     #[ORM\ManyToMany(targetEntity: Tag::class)]
diff --git a/tests/Doctrine/fixtures/source_project/src/Entity/Embed.php b/tests/Doctrine/fixtures/source_project/src/Entity/Embed.php
@@ -8,6 +8,6 @@
 #[ORM\Embeddable]
 class Embed
 {
-    #[ORM\Column()]
+    #[ORM\Column]
     private ?int $val = null;
 }
diff --git a/tests/Doctrine/fixtures/source_project/src/Entity/Tag.php b/tests/Doctrine/fixtures/source_project/src/Entity/Tag.php
@@ -10,7 +10,7 @@ class Tag
 {
     #[ORM\Id]
     #[ORM\GeneratedValue]
-    #[ORM\Column()]
+    #[ORM\Column]
     private ?int $id = null;
 
     public function getId(): ?int
diff --git a/tests/Doctrine/fixtures/source_project/src/Entity/User.php b/tests/Doctrine/fixtures/source_project/src/Entity/User.php
@@ -11,7 +11,7 @@ class User
 {
     #[ORM\Id]
     #[ORM\GeneratedValue]
-    #[ORM\Column()]
+    #[ORM\Column]
     private ?int $id = null;
 
     #[ORM\OneToMany(targetEntity: UserAvatar::class, mappedBy: 'user')]
diff --git a/tests/Doctrine/fixtures/source_project/src/Entity/UserAvatar.php b/tests/Doctrine/fixtures/source_project/src/Entity/UserAvatar.php
@@ -9,7 +9,7 @@ class UserAvatar
 {
     #[ORM\Id]
     #[ORM\GeneratedValue]
-    #[ORM\Column()]
+    #[ORM\Column]
     private ?int $id = null;
 
     #[ORM\ManyToOne(inversedBy: 'avatars', cascade: ['persist', 'remove'])]
diff --git a/tests/Doctrine/fixtures/source_project/src/Entity/UserProfile.php b/tests/Doctrine/fixtures/source_project/src/Entity/UserProfile.php
@@ -10,7 +10,7 @@ class UserProfile
 {
     #[ORM\Id]
     #[ORM\GeneratedValue]
-    #[ORM\Column()]
+    #[ORM\Column]
     private ?int $id = null;
 
     #[ORM\OneToOne(inversedBy: 'userProfile', cascade: ['persist', 'remove'])]
diff --git a/tests/fixtures/make-entity/entities/attributes/User-basic.php b/tests/fixtures/make-entity/entities/attributes/User-basic.php
@@ -9,7 +9,7 @@ class User
 {
     #[ORM\Id]
     #[ORM\GeneratedValue]
-    #[ORM\Column()]
+    #[ORM\Column]
     private ?int $id = null;
 
     #[ORM\Column(length: 255, nullable: true)]
diff --git a/tests/fixtures/make-entity/entities/attributes/User-custom-namespace.php b/tests/fixtures/make-entity/entities/attributes/User-custom-namespace.php
@@ -9,7 +9,7 @@ class User
 {
     #[ORM\Id]
     #[ORM\GeneratedValue]
-    #[ORM\Column()]
+    #[ORM\Column]
     private ?int $id = null;
 
     #[ORM\Column(length: 255, nullable: true)]
diff --git a/tests/fixtures/make-entity/entities/attributes/User-invalid-method-no-property.php b/tests/fixtures/make-entity/entities/attributes/User-invalid-method-no-property.php
@@ -9,7 +9,7 @@ class User
 {
     #[ORM\Id]
     #[ORM\GeneratedValue]
-    #[ORM\Column()]
+    #[ORM\Column]
     private ?int $id = null;
 
     public function getId()
diff --git a/tests/fixtures/make-entity/entities/attributes/User-invalid-method.php b/tests/fixtures/make-entity/entities/attributes/User-invalid-method.php
@@ -9,7 +9,7 @@ class User
 {
     #[ORM\Id]
     #[ORM\GeneratedValue]
-    #[ORM\Column()]
+    #[ORM\Column]
     private ?int $id = null;
 
     #[ORM\Column(length: 255, nullable: true)]
diff --git a/tests/fixtures/make-entity/entities/attributes/UserAvatarPhoto-basic.php b/tests/fixtures/make-entity/entities/attributes/UserAvatarPhoto-basic.php
@@ -9,7 +9,7 @@ class UserAvatarPhoto
 {
     #[ORM\Id]
     #[ORM\GeneratedValue]
-    #[ORM\Column()]
+    #[ORM\Column]
     private ?int $id = null;
 
     public function getId()
diff --git a/tests/fixtures/make-entity/regenerate-embedded/attributes/src/Entity/Invoice.php b/tests/fixtures/make-entity/regenerate-embedded/attributes/src/Entity/Invoice.php
@@ -9,7 +9,7 @@ class Invoice
 {
     #[ORM\Id]
     #[ORM\GeneratedValue(strategy: 'AUTO')]
-    #[ORM\Column()]
+    #[ORM\Column]
     private ?int $id = null;
 
     #[ORM\Column(length: 255, name: 'title')]
diff --git a/tests/fixtures/make-entity/regenerate/attributes/src/Entity/User.php b/tests/fixtures/make-entity/regenerate/attributes/src/Entity/User.php
@@ -11,7 +11,7 @@ class User
 {
     #[ORM\Id]
     #[ORM\GeneratedValue]
-    #[ORM\Column()]
+    #[ORM\Column]
     private ?int $id = null;
 
     #[ORM\Column(length: 255, nullable: true)]
diff --git a/tests/fixtures/make-entity/regenerate/attributes/src/Entity/UserAvatar.php b/tests/fixtures/make-entity/regenerate/attributes/src/Entity/UserAvatar.php
@@ -9,7 +9,7 @@ class UserAvatar
 {
     #[ORM\Id]
     #[ORM\GeneratedValue]
-    #[ORM\Column()]
+    #[ORM\Column]
     private ?int $id = null;
 
     #[ORM\ManyToOne(inversedBy: 'avatars', cascade: ['persist', 'remove'])]

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ class <?= $class_name."\n" ?>`
`17`	`17`	`{`
`18`	`18`	`#[ORM\Id]`
`19`	`19`	`#[ORM\GeneratedValue]`
`20`		`- #[ORM\Column()]`
	`20`	`+ #[ORM\Column]`
`21`	`21`	`private ?int $id = null;`
`22`	`22`
`23`	`23`	`public function getId(): ?int`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`#[ORM\Embeddable]`
`9`	`9`	`class Embed`
`10`	`10`	`{`
`11`		`- #[ORM\Column()]`
	`11`	`+ #[ORM\Column]`
`12`	`12`	`private ?int $val = null;`
`13`	`13`
`14`	`14`	`public function getVal(): ?int`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ class Tag`
`10`	`10`	`{`
`11`	`11`	`#[ORM\Id]`
`12`	`12`	`#[ORM\GeneratedValue]`
`13`		`- #[ORM\Column()]`
	`13`	`+ #[ORM\Column]`
`14`	`14`	`private ?int $id = null;`
`15`	`15`
`16`	`16`	`public function getId(): ?int`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ class User`
`11`	`11`	`{`
`12`	`12`	`#[ORM\Id]`
`13`	`13`	`#[ORM\GeneratedValue]`
`14`		`- #[ORM\Column()]`
	`14`	`+ #[ORM\Column]`
`15`	`15`	`private ?int $id = null;`
`16`	`16`
`17`	`17`	`#[ORM\OneToMany(targetEntity: UserAvatar::class, mappedBy: 'user')]`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ class UserAvatar`
`9`	`9`	`{`
`10`	`10`	`#[ORM\Id]`
`11`	`11`	`#[ORM\GeneratedValue]`
`12`		`- #[ORM\Column()]`
	`12`	`+ #[ORM\Column]`
`13`	`13`	`private ?int $id = null;`
`14`	`14`
`15`	`15`	`#[ORM\ManyToOne(inversedBy: 'avatars', cascade: ['persist', 'remove'])]`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ class UserProfile`
`10`	`10`	`{`
`11`	`11`	`#[ORM\Id]`
`12`	`12`	`#[ORM\GeneratedValue]`
`13`		`- #[ORM\Column()]`
	`13`	`+ #[ORM\Column]`
`14`	`14`	`private ?int $id = null;`
`15`	`15`
`16`	`16`	`#[ORM\OneToOne(inversedBy: 'userProfile', cascade: ['persist', 'remove'])]`
Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,6 @@`
`8`	`8`	`#[ORM\Embeddable]`
`9`	`9`	`class Embed`
`10`	`10`	`{`
`11`		`- #[ORM\Column()]`
	`11`	`+ #[ORM\Column]`
`12`	`12`	`private ?int $val = null;`
`13`	`13`	`}`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ class User`
`9`	`9`	`{`
`10`	`10`	`#[ORM\Id]`
`11`	`11`	`#[ORM\GeneratedValue]`
`12`		`- #[ORM\Column()]`
	`12`	`+ #[ORM\Column]`
`13`	`13`	`private ?int $id = null;`
`14`	`14`
`15`	`15`	`#[ORM\Column(length: 255, nullable: true)]`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ class UserAvatarPhoto`
`9`	`9`	`{`
`10`	`10`	`#[ORM\Id]`
`11`	`11`	`#[ORM\GeneratedValue]`
`12`		`- #[ORM\Column()]`
	`12`	`+ #[ORM\Column]`
`13`	`13`	`private ?int $id = null;`
`14`	`14`
`15`	`15`	`public function getId()`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ class Invoice`
`9`	`9`	`{`
`10`	`10`	`#[ORM\Id]`
`11`	`11`	`#[ORM\GeneratedValue(strategy: 'AUTO')]`
`12`		`- #[ORM\Column()]`
	`12`	`+ #[ORM\Column]`
`13`	`13`	`private ?int $id = null;`
`14`	`14`
`15`	`15`	`#[ORM\Column(length: 255, name: 'title')]`