minor #274 [WIP] Fix windows tests issues and speed (sadikoff)

This PR was merged into the 1.0-dev branch.

Discussion
----------

[WIP] Fix windows tests issues and speed

Trying to fix all tests issues. Still in progress...

Commits
-------

9404111 Tests are back again. New git env is ready thx to @nikophil for idea

Author: weaverryan

.travis.yml

@@ -20,13 +20,13 @@ env:
     global:
         - SYMFONY_PHPUNIT_DIR=.phpunit
 
+before_install:
+    - phpenv config-rm xdebug.ini
+
 install:
     - composer install
     - ./vendor/bin/simple-phpunit install
 
-before_script:
-    - phpenv config-rm xdebug.ini
-
 script:
     - ./vendor/bin/simple-phpunit
     - ./vendor/bin/php-cs-fixer fix --dry-run --diff

appveyor.yml

@@ -1,18 +1,16 @@
 build: false
 platform:
     - x64
-clone_folder: c:\projects\maker-bundle
+clone_folder: C:\projects\maker-bundle
 
 cache:
-    - '%LOCALAPPDATA%\Composer\files -> composer.lock'
-    - composer.phar
+    - C:\projects\maker-bundle\vendor -> composer.json
     # Cache chocolatey packages
     - C:\ProgramData\chocolatey\bin -> .appveyor.yml
     - C:\ProgramData\chocolatey\lib -> .appveyor.yml
     # Cache php install
     - C:\tools\php -> .appveyor.yml
     - .phpunit -> phpunit
-    - C:\projects\maker-bundle\vendor -> composer.json
 
 services:
   - mysql
@@ -26,8 +24,6 @@ init:
 environment:
     TEST_DATABASE_DSN: mysql://root:[email protected]:3306/test_maker
     matrix:
-      - dependencies: lowest
-        php_ver_target: 7.1.3
       - dependencies: highest
         php_ver_target: 7.2.3
 
@@ -39,10 +35,10 @@ install:
     - IF %PHP%==0 copy php.ini-development php.ini /Y
     - IF %PHP%==0 echo memory_limit=-1 >> php.ini
     - IF %PHP%==0 echo serialize_precision=14 >> php.ini
+    - IF %PHP%==0 echo realpath_cache_size=8192k >> php.ini
     - IF %PHP%==0 echo max_execution_time=1200 >> php.ini
     - IF %PHP%==0 echo date.timezone="UTC" >> php.ini
     - IF %PHP%==0 echo extension_dir=ext >> php.ini
-    - IF %PHP%==0 echo zend_extension=php_opcache.dll >> php.ini
     - IF %PHP%==0 echo opcache.enable_cli=1 >> php.ini
     - IF %PHP%==0 echo extension=php_openssl.dll >> php.ini
     - IF %PHP%==0 echo extension=php_mbstring.dll >> php.ini
@@ -52,9 +48,7 @@ install:
     - IF %PHP%==0 echo extension=php_pdo_mysql.dll >> php.ini
     - IF %PHP%==0 echo @php %%~dp0composer.phar %%* > composer.bat
     - appveyor-retry appveyor DownloadFile https://getcomposer.org/composer.phar
-    - composer global require hirak/prestissimo --no-progress
     - cd C:\projects\maker-bundle
-    - IF %dependencies%==lowest appveyor-retry composer update --prefer-lowest --no-progress --no-suggest --ansi
     - IF %dependencies%==highest appveyor-retry composer update --no-progress --no-suggest --ansi
     - vendor/bin/simple-phpunit install
 

src/Test/MakerTestCase.php

@@ -26,41 +26,37 @@ protected function executeMakerCommand(MakerTestDetails $testDetails)
         // prepare environment to test
         $testEnv->prepare();
 
-        try {
-            // run tests
-            $makerTestProcess = $testEnv->runMaker();
-            $files = $testEnv->getGeneratedFilesFromOutputText();
+        // run tests
+        $makerTestProcess = $testEnv->runMaker();
+        $files = $testEnv->getGeneratedFilesFromOutputText();
 
-            foreach ($files as $file) {
-                $this->assertTrue($testEnv->fileExists($file));
+        foreach ($files as $file) {
+            $this->assertTrue($testEnv->fileExists($file));
 
-                if ('.php' === substr($file, -4)) {
-                    $csProcess = $testEnv->runPhpCSFixer($file);
+            if ('.php' === substr($file, -4)) {
+                $csProcess = $testEnv->runPhpCSFixer($file);
 
-                    $this->assertTrue($csProcess->isSuccessful(), sprintf('File "%s" has a php-cs problem: %s', $file, $csProcess->getOutput()));
-                }
+                $this->assertTrue($csProcess->isSuccessful(), sprintf('File "%s" has a php-cs problem: %s', $file, $csProcess->getOutput()));
+            }
 
-                if ('.twig' === substr($file, -5)) {
-                    $csProcess = $testEnv->runTwigCSLint($file);
+            if ('.twig' === substr($file, -5)) {
+                $csProcess = $testEnv->runTwigCSLint($file);
 
-                    $this->assertTrue($csProcess->isSuccessful(), sprintf('File "%s" has a twig-cs problem: %s', $file, $csProcess->getOutput()));
-                }
+                $this->assertTrue($csProcess->isSuccessful(), sprintf('File "%s" has a twig-cs problem: %s', $file, $csProcess->getOutput()));
             }
+        }
 
-            // run internal tests
-            $internalTestProcess = $testEnv->runInternalTests();
-            if (null !== $internalTestProcess) {
-                $this->assertTrue($internalTestProcess->isSuccessful(), sprintf("Error while running the PHPUnit tests *in* the project: \n\n %s \n\n Command Output: %s", $internalTestProcess->getOutput(), $makerTestProcess->getOutput()));
-            }
+        // run internal tests
+        $internalTestProcess = $testEnv->runInternalTests();
+        if (null !== $internalTestProcess) {
+            $this->assertTrue($internalTestProcess->isSuccessful(), sprintf("Error while running the PHPUnit tests *in* the project: \n\n %s \n\n Command Output: %s", $internalTestProcess->getOutput(), $makerTestProcess->getOutput()));
+        }
 
-            // checkout user asserts
-            if (null === $testDetails->getAssert()) {
-                $this->assertContains('Success', $makerTestProcess->getOutput(), $makerTestProcess->getErrorOutput());
-            } else {
-                ($testDetails->getAssert())($makerTestProcess->getOutput(), $testEnv->getPath());
-            }
-        } finally {
-            $testEnv->reset();
+        // checkout user asserts
+        if (null === $testDetails->getAssert()) {
+            $this->assertContains('Success', $makerTestProcess->getOutput(), $makerTestProcess->getErrorOutput());
+        } else {
+            ($testDetails->getAssert())($makerTestProcess->getOutput(), $testEnv->getPath());
         }
     }
 

src/Test/MakerTestDetails.php

@@ -24,8 +24,6 @@ final class MakerTestDetails
 
     private $deletedFiles = [];
 
-    private $filesToRevert = [];
-
     private $replacements = [];
 
     private $postMakeReplacements = [];
@@ -42,7 +40,7 @@ final class MakerTestDetails
 
     private $commandAllowedToFail = false;
 
-    private $snapshotSuffix = '';
+    private $rootNamespace = 'App';
 
     private $requiredPhpVersion;
 
@@ -72,44 +70,16 @@ public function setFixtureFilesPath(string $fixtureFilesPath): self
         return $this;
     }
 
-    public function changeRootNamespace(string $rootNamespace): self
+    public function getRootNamespace()
     {
-        $rootNamespace = trim($rootNamespace, '\\');
+        return $this->rootNamespace;
+    }
 
-        // to bypass read before flush issue
-        $this->snapshotSuffix = $rootNamespace;
+    public function changeRootNamespace(string $rootNamespace): self
+    {
+        $this->rootNamespace = trim($rootNamespace, '\\');
 
-        return $this
-            ->addReplacement(
-                'composer.json',
-                '"App\\\\": "src/"',
-                '"'.$rootNamespace.'\\\\": "src/"'
-            )
-            ->addReplacement(
-                'src/Kernel.php',
-                'namespace App',
-                'namespace '.$rootNamespace
-            )
-            ->addReplacement(
-                'bin/console',
-                'use App\\Kernel',
-                'use '.$rootNamespace.'\\Kernel'
-            )
-            ->addReplacement(
-                'public/index.php',
-                'use App\\Kernel',
-                'use '.$rootNamespace.'\\Kernel'
-            )
-            ->addReplacement(
-                'config/services.yaml',
-                'App\\',
-                $rootNamespace.'\\'
-            )
-            ->addReplacement(
-                'phpunit.xml.dist',
-                '<env name="KERNEL_CLASS" value="App\\Kernel" />',
-                '<env name="KERNEL_CLASS" value="'.$rootNamespace.'\\Kernel" />'
-            );
+        return $this;
     }
 
     public function addPreMakeCommand(string $preMakeCommand): self
@@ -138,18 +108,6 @@ public function getFilesToDelete(): array
         return $this->deletedFiles;
     }
 
-    public function revertFileAfterFinish(string $filename): self
-    {
-        $this->filesToRevert[] = $filename;
-
-        return $this;
-    }
-
-    public function getFilesToRevert(): array
-    {
-        return $this->filesToRevert;
-    }
-
     public function addReplacement(string $filename, string $find, string $replace): self
     {
         $this->replacements[] = [
@@ -269,7 +227,6 @@ public function setRequiredPhpVersion(int $version): self
     public function setGuardAuthenticator(string $firewallName, string $id): self
     {
         $this->guardAuthenticators[$firewallName] = $id;
-        $this->revertFileAfterFinish('config/packages/security.yaml');
 
         return $this;
     }
@@ -286,9 +243,9 @@ public function getFixtureFilesPath()
 
     public function getUniqueCacheDirectoryName(): string
     {
-        // for cache purposes, only the dependencies are important
-        // shortened to avoid long paths on Windows
-        return 'maker_'.substr(md5(serialize($this->getDependencies()).$this->snapshotSuffix), 0, 10);
+        // for cache purposes, only the dependencies are important!
+        // You can change it ONLY if you don't have another way to implement it
+        return 'maker_'.strtolower($this->getRootNamespace()).'_'.md5(serialize($this->getDependencies()));
     }
 
     public function getPreMakeCommands(): array