Skip to content

Commit 387c24d

Browse files
committed
minor #1065 [ci] allow panther <2.0 in tests (jrushlow)
This PR was merged into the 1.0-dev branch. Discussion ---------- [ci] allow panther <2.0 in tests Panther `>= 2.x` only supports PHP >= `8.0`. We still need to use Panther `1.x` for PHP `7.x` tests until PHP 7 support is dropped in MakerBundle Commits ------- 3e923a6 [ci] allow panther <2.0 in tests
2 parents 88bb706 + 3e923a6 commit 387c24d

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

tests/Maker/MakeFunctionalTestTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ protected function getMakerClass(): string
2828
public function getTestDetails()
2929
{
3030
yield 'it_generates_test_with_panther' => [$this->createMakerTest()
31-
->addExtraDependencies('panther')
31+
/* @legacy Allows Panther >= 1.x to be installed. (PHP <8.0 support) */
32+
->addExtraDependencies('panther:*')
3233
->run(function (MakerTestRunner $runner) {
3334
$runner->copy(
3435
'make-functional/MainController.php',

tests/Maker/MakeTestTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,8 @@ public function getTestDetails()
8080
];
8181

8282
yield 'it_makes_PantherTestCase_type' => [$this->createMakerTest()
83-
->addExtraDependencies('panther')
83+
/* @legacy Allows Panther >= 1.x to be installed. (PHP <8.0 support) */
84+
->addExtraDependencies('panther:*')
8485
->run(function (MakerTestRunner $runner) {
8586
$runner->copy(
8687
'make-test/basic_setup',

0 commit comments

Comments
 (0)