CS Fixer

Author: maelanleborgne

src/Maker/MakeWebhook.php

@@ -54,7 +54,6 @@
  */
 final class MakeWebhook extends AbstractMaker implements InputAwareMakerInterface
 {
-
     private const WEBHOOK_CONFIG_PATH = 'config/packages/webhook.yaml';
     private YamlSourceManipulator $ysm;
 
@@ -77,14 +76,14 @@ public static function getCommandDescription(): string
     public function configureCommand(Command $command, InputConfiguration $inputConfig): void
     {
         $command
-            ->addArgument('name', InputArgument::OPTIONAL, sprintf('Name of the webhook to create (e.g. <fg=yellow>github, stripe, ...</>)'))
-            ->setHelp(file_get_contents(__DIR__ . '/../Resources/help/MakeWebhook.txt'))
+            ->addArgument('name', InputArgument::OPTIONAL, 'Name of the webhook to create (e.g. <fg=yellow>github, stripe, ...</>)')
+            ->setHelp(file_get_contents(__DIR__.'/../Resources/help/MakeWebhook.txt'))
         ;
 
         $inputConfig->setArgumentAsNonInteractive('name');
     }
 
-    public function configureDependencies(DependencyBuilder $dependencies, ?InputInterface $input = null)
+    public function configureDependencies(DependencyBuilder $dependencies, InputInterface $input = null)
     {
         $dependencies->addClassDependency(
             AbstractRequestParser::class,
@@ -132,11 +131,11 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
     {
         $webhookName = $input->getArgument('name');
         $requestParserDetails = $this->generator->createClassNameDetails(
-            Str::asClassName($webhookName . 'RequestParser'),
+            Str::asClassName($webhookName.'RequestParser'),
             'Webhook\\'
         );
         $remoteEventHandlerDetails = $this->generator->createClassNameDetails(
-            Str::asClassName($webhookName . 'WebhookHandler'),
+            Str::asClassName($webhookName.'WebhookHandler'),
             'RemoteEvent\\'
         );
 
@@ -165,7 +164,7 @@ private function addToYamlConfig(string $webhookName, ClassNameDetails $requestP
         }
         $this->ysm = new YamlSourceManipulator($yamlConfig);
         $arrayConfig = $this->ysm->getData();
-        if (key_exists($webhookName, $arrayConfig['framework']['webhook']['routing'] ?? [])) {
+        if (\array_key_exists($webhookName, $arrayConfig['framework']['webhook']['routing'] ?? [])) {
             throw new \InvalidArgumentException('A webhook with this name already exists');
         }
 
@@ -179,9 +178,6 @@ private function addToYamlConfig(string $webhookName, ClassNameDetails $requestP
     }
 
     /**
-     * @param ConsoleStyle $io
-     * @param ClassNameDetails $requestParserDetails
-     * @return void
      * @throws \Exception
      */
     public function generateRequestParser(ConsoleStyle $io, ClassNameDetails $requestParserDetails): void
@@ -253,6 +249,7 @@ private function askForNextRequestMatcher(ConsoleStyle $io, array $addedMatchers
                 return null;
             }
         }
+
         return $matcherName;
     }
 

tests/Maker/MakeWebhookTest.php

@@ -143,11 +143,11 @@ public function getTestDetails(): \Generator
                 );
                 $this->assertStringContainsString(
                     <<<EOF
-                            return new ChainRequestMatcher([
-                                new IsJsonRequestMatcher(),
-                                new PortRequestMatcher(443),
-                            ]);
-                    EOF,
+                                return new ChainRequestMatcher([
+                                    new IsJsonRequestMatcher(),
+                                    new PortRequestMatcher(443),
+                                ]);
+                        EOF,
                     $requestParserSource
                 );
             }),
@@ -156,7 +156,6 @@ public function getTestDetails(): \Generator
         yield 'it_makes_webhook_with_expression_language_injection' => [$this->createMakerTest()
             ->addExtraDependencies('symfony/expression-language')
             ->run(function (MakerTestRunner $runner) {
-
                 $output = $runner->runMaker([
                     // webhook name
                     'remote_service',
@@ -190,11 +189,11 @@ public function getTestDetails(): \Generator
                 );
                 $this->assertStringContainsString(
                     <<<EOF
-                            return new ChainRequestMatcher([
-                                new IsJsonRequestMatcher(),
-                                new ExpressionRequestMatcher(new ExpressionLanguage(), new Expression('expression')),
-                            ]);
-                    EOF,
+                                return new ChainRequestMatcher([
+                                    new IsJsonRequestMatcher(),
+                                    new ExpressionRequestMatcher(new ExpressionLanguage(), new Expression('expression')),
+                                ]);
+                        EOF,
                     $requestParserSource
                 );
             }),