Skip to content

Commit 50c7d96

Browse files
authored
minor #1495 [ci] minor refactor to allow for more regex tests
refs: #1491
1 parent fd6b34a commit 50c7d96

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

tests/RegexTest.php

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,19 +14,27 @@
1414
use PHPUnit\Framework\TestCase;
1515
use Symfony\Bundle\MakerBundle\Test\MakerTestEnvironment;
1616

17+
/**
18+
* Common class for testing regex's used in MakerBundle.
19+
*
20+
* Create a new test method and dataProvider to test regex
21+
* expressions introduced in MakerBundle
22+
*
23+
* @author Jesse Rushlow <[email protected]>
24+
*/
1725
class RegexTest extends TestCase
1826
{
19-
/** @dataProvider regexDataProvider */
20-
public function testRegex(string $data, array $expectedResult): void
27+
/** @dataProvider generatedFilesRegexDataProvider */
28+
public function testMakerTestEnvironmentGeneratedFilesRegex(string $subjectData, array $expectedResult): void
2129
{
2230
$result = [];
2331

24-
preg_match_all(MakerTestEnvironment::GENERATED_FILES_REGEX, $data, $result, \PREG_PATTERN_ORDER);
32+
preg_match_all(MakerTestEnvironment::GENERATED_FILES_REGEX, $subjectData, $result, \PREG_PATTERN_ORDER);
2533

2634
self::assertSame($expectedResult, $result[1]);
2735
}
2836

29-
public function regexDataProvider(): \Generator
37+
private function generatedFilesRegexDataProvider(): \Generator
3038
{
3139
yield 'Created Prefix' => ['created: test/something.php', ['test/something.php']];
3240
yield 'Updated Prefix' => ['updated: test/something.php', ['test/something.php']];

0 commit comments

Comments
 (0)