no looking for a global php-cs-fixer

Author: jrushlow

src/Util/TemplateLinter.php

@@ -12,7 +12,6 @@
 namespace Symfony\Bundle\MakerBundle\Util;
 
 use Symfony\Bundle\MakerBundle\Exception\RuntimeCommandException;
-use Symfony\Component\Process\ExecutableFinder;
 use Symfony\Component\Process\Process;
 
 /**
@@ -31,8 +30,8 @@ public function __construct(
         private ?string $phpCsFixerBinaryPath = null,
         private ?string $phpCsFixerConfigPath = null,
     ) {
-        $this->setConfig();
         $this->setBinary();
+        $this->setConfig();
     }
 
     public function lintFiles(array $templateFilePaths): void
@@ -91,29 +90,6 @@ private function setBinary(): void
             return;
         }
 
-        $finder = new ExecutableFinder();
-        $finder->addSuffix('.phar');
-
-        ($process = Process::fromShellCommandline('composer config bin-dir && composer global config bin-dir --absolute'))
-            ->run();
-
-        $composerBinPaths = explode(\PHP_EOL, $process->getOutput());
-
-        $this->phpCsFixerBinaryPath = $finder->find(
-            name: 'php-cs-fixer',
-            extraDirs: [
-                ...$composerBinPaths,
-                'tools/php-cs-fixer/vendor/bin',
-                'tools/php-cs-fixer/bin',
-            ]
-        );
-
-        if (null !== $this->phpCsFixerBinaryPath) {
-            $this->usingBundledPhpCsFixer = false;
-
-            return;
-        }
-
         $this->phpCsFixerBinaryPath = \dirname(__DIR__).'/Resources/bin/php-cs-fixer-v3.13.0.phar';
     }
 

tests/Maker/TemplateLinterTest.php

@@ -79,7 +79,7 @@ public function getTestDetails(): \Generator
 
                 self::assertStringContainsString('Linted with stock php-cs-config', $generatedTemplate);
 
-                $expectedOutput = 'System PHP-CS-Fixer (bin/php-cs-fixer) & System PHP-CS-Fixer Configuration (.php-cs-fixer.dist.php)';
+                $expectedOutput = 'Bundled PHP-CS-Fixer & System PHP-CS-Fixer Configuration (.php-cs-fixer.dist.php)';
                 self::assertStringContainsString($expectedOutput, $output);
             }),
         ];
@@ -93,31 +93,5 @@ public function getTestDetails(): \Generator
                 self::assertStringContainsString($expectedOutput, $output);
             }),
         ];
-
-        yield 'lints_templates_with_php_cs_fixer_in_tools_dir' => [$this->createMakerTest()
-            ->run(function (MakerTestRunner $runner) {
-                $runner->writeFile('tools/php-cs-fixer/.gitignore', ''); // create the dir
-                $runner->runProcess('composer require --working-dir=tools/php-cs-fixer friendsofphp/php-cs-fixer');
-
-                // Voter class name
-                $output = $runner->runMaker(['FooBar']);
-
-                $expectedOutput = 'System PHP-CS-Fixer (tools/php-cs-fixer/bin/php-cs-fixer) & Bundled PHP-CS-Fixer Configuration';
-                self::assertStringContainsString($expectedOutput, $output);
-            }),
-        ];
-
-        yield 'lints_templates_with_composer_global_php_cs_fixer' => [$this->createMakerTest()
-            ->run(function (MakerTestRunner $runner) {
-                $runner->runProcess('composer global require friendsofphp/php-cs-fixer');
-
-                // Voter class name
-                $output = $runner->runMaker(['FooBar']);
-
-                // We don't know the prefix to the global "composer" dir. e.g. /your/system/composer/....
-                $expectedOutput = 'composer/bin/php-cs-fixer) & Bundled PHP-CS-Fixer Configuration';
-                self::assertStringContainsString($expectedOutput, $output);
-            }),
-        ];
     }
 }