Skip to content

Commit 8b66111

Browse files
committed
minor #538 temp. disable make forgotten password (jrushlow)
This PR was squashed before being merged into the 1.0-dev branch (closes #538). Discussion ---------- temp. disable make forgotten password In reference to issue #537 Commits ------- 61a9eae temp. disable make forgotten password
2 parents 61cf560 + 61a9eae commit 8b66111

File tree

3 files changed

+20
-6
lines changed

3 files changed

+20
-6
lines changed

src/Resources/config/makers.xml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,14 @@
4242
<tag name="maker.command" />
4343
</service>
4444

45-
<service id="maker.maker.make_forgotten_password" class="Symfony\Bundle\MakerBundle\Maker\MakeForgottenPassword">
46-
<argument type="service" id="maker.file_manager" />
47-
<argument type="service" id="maker.renderer.form_type_renderer" />
48-
<argument type="service" id="router" />
49-
<tag name="maker.command" />
50-
</service>
45+
<!-- Temporary disable make forgotten password pending refactor. Allow's for other MakerBundle releases. -->
46+
<!-- See https://github.com/symfony/maker-bundle/issues/537 -->
47+
<!-- <service id="maker.maker.make_forgotten_password" class="Symfony\Bundle\MakerBundle\Maker\MakeForgottenPassword">-->
48+
<!-- <argument type="service" id="maker.file_manager" />-->
49+
<!-- <argument type="service" id="maker.renderer.form_type_renderer" />-->
50+
<!-- <argument type="service" id="router" />-->
51+
<!-- <tag name="maker.command" />-->
52+
<!-- </service>-->
5153

5254
<service id="maker.maker.make_form" class="Symfony\Bundle\MakerBundle\Maker\MakeForm">
5355
<argument type="service" id="maker.doctrine_helper" />

tests/Maker/FunctionalTest.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
use Symfony\Bundle\FrameworkBundle\Console\Application;
1616
use Symfony\Bundle\MakerBundle\Command\MakerCommand;
1717
use Symfony\Bundle\MakerBundle\Maker\AbstractMaker;
18+
use Symfony\Bundle\MakerBundle\Maker\MakeForgottenPassword;
1819
use Symfony\Bundle\MakerBundle\Test\MakerTestKernel;
1920
use Symfony\Component\Finder\Finder;
2021

@@ -39,6 +40,11 @@ public function testWiring()
3940
continue;
4041
}
4142

43+
/** Skip make forgotten password as it is temp. disabled (tkt#537) */
44+
if (MakeForgottenPassword::class === $class) {
45+
continue;
46+
}
47+
4248
$commandName = $class::getCommandName();
4349
// if the command does not exist, this will explode
4450
$command = $application->find($commandName);

tests/Maker/MakeForgottenPasswordTest.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,14 @@
88

99
class MakeForgottenPasswordTest extends MakerTestCase
1010
{
11+
/**
12+
* Test skipped until make forgotten password is enabled again.
13+
* @see https://github.com/symfony/maker-bundle/issues/537
14+
*/
1115
public function getTestDetails()
1216
{
17+
$this->markTestSkipped('Temp. Disabled make forgotten password. See ');
18+
1319
yield 'forgotten_password' => [MakerTestDetails::createTest(
1420
$this->getMakerInstance(MakeForgottenPassword::class),
1521
[

0 commit comments

Comments
 (0)