refactoring

- set empty path for app_forgot_password_request route
- add tests for all routes
- minor cs issues

Author: jrushlow

src/Resources/skeleton/resetPassword/ResetPasswordController.tpl.php

@@ -35,7 +35,7 @@ public function __construct(ResetPasswordHelperInterface $resetPasswordHelper)
     /**
      * Display & process form to request a password reset.
      *
-     * @Route(name="app_forgot_password_request")
+     * @Route("", name="app_forgot_password_request")
      */
     public function request(Request $request, MailerInterface $mailer): Response
     {

tests/fixtures/MakeResetPassword/src/Entity/User.php

@@ -6,7 +6,6 @@
 
 class User implements UserInterface
 {
-
     private $email;
 
     public function getEmail()

tests/fixtures/MakeResetPasswordFunctionalTest/src/Entity/User.php

@@ -6,7 +6,6 @@
 
 class User implements UserInterface
 {
-
     private $email;
 
     public function getEmail()

tests/fixtures/MakeResetPasswordFunctionalTest/tests/ResetPasswordFunctionalTest.php

@@ -2,16 +2,32 @@
 
 namespace App\Tests;
 
-use Symfony\Bundle\FrameworkBundle\KernelBrowser;
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
 
 class ResetPasswordFunctionalTest extends WebTestCase
 {
-    public function testResetPassword()
+    public function testResetRequestRoute()
     {
         $client = static::createClient();
         $client->request('GET', '/reset-password');
 
         $this->assertSame(200, $client->getResponse()->getStatusCode());
     }
+
+    public function testResetRequestRouteDeniesInvalidToken()
+    {
+        $client = static::createClient();
+        $client->request('GET', '/reset-password/reset/badToken1234');
+
+        $this->assertSame(302, $client->getResponse()->getStatusCode());
+    }
+
+    public function testCheckEmailRouteRedirectsToRequestRouteIfUserNotAllowedToCheckEmail()
+    {
+        $client = static::createClient();
+        $client->request('GET', '/reset-password/check-email');
+
+        $this->assertSame(302, $client->getResponse()->getStatusCode());
+        $this->assertResponseRedirects('/reset-password');
+    }
 }