lets use a factory method to generate the helper

Author: jrushlow

src/Generator.php

@@ -16,6 +16,7 @@
 use Symfony\Bundle\MakerBundle\Exception\RuntimeCommandException;
 use Symfony\Bundle\MakerBundle\Util\ClassNameDetails;
 use Symfony\Bundle\MakerBundle\Util\PhpCompatUtil;
+use Symfony\Bundle\MakerBundle\Util\TemplateClassDetails;
 
 /**
  * @author Javier Eguiluz <[email protected]>
@@ -156,6 +157,11 @@ public function createClassNameDetails(string $name, string $namespacePrefix, st
         return new ClassNameDetails($className, $fullNamespacePrefix, $suffix);
     }
 
+    public function createClassHelper(string $fullyQualifiedClassName): TemplateClassDetails
+    {
+        return new TemplateClassDetails($fullyQualifiedClassName, $this->phpCompatUtil->canUseTypedProperties());
+    }
+
     public function getRootDirectory(): string
     {
         return $this->fileManager->getRootDirectory();

src/Maker/MakeRegistrationForm.php

@@ -66,7 +66,6 @@ final class MakeRegistrationForm extends AbstractMaker
     private $formTypeRenderer;
     private $router;
     private $doctrineHelper;
-    private $phpCompatUtil;
 
     private $userClass;
     private $usernameField;
@@ -82,13 +81,12 @@ final class MakeRegistrationForm extends AbstractMaker
     private $redirectRouteName;
     private $addUniqueEntityConstraint;
 
-    public function __construct(FileManager $fileManager, FormTypeRenderer $formTypeRenderer, RouterInterface $router, DoctrineHelper $doctrineHelper, PhpCompatUtil $phpCompatUtil)
+    public function __construct(FileManager $fileManager, FormTypeRenderer $formTypeRenderer, RouterInterface $router, DoctrineHelper $doctrineHelper)
     {
         $this->fileManager = $fileManager;
         $this->formTypeRenderer = $formTypeRenderer;
         $this->router = $router;
         $this->doctrineHelper = $doctrineHelper;
-        $this->phpCompatUtil = $phpCompatUtil;
     }
 
     public static function getCommandName(): string
@@ -321,7 +319,7 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
                     'user_class_name' => $userClassNameDetails->getShortName(),
                     'password_field' => $this->passwordField,
                     'will_verify_email' => $this->willVerifyEmail,
-                    'email_verifier_details' => new TemplateClassDetails($verifyEmailServiceClassNameDetails->getFullName(), $this->phpCompatUtil->canUseTypedProperties()),
+                    'email_verifier_class' => $generator->createClassHelper($verifyEmailServiceClassNameDetails->getFullName()),
                     'verify_email_anonymously' => $this->verifyEmailAnonymously,
                     'from_email' => $this->fromEmailAddress,
                     'from_email_name' => $this->fromEmailName,
@@ -330,7 +328,7 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
                     'authenticator_full_class_name' => $this->autoLoginAuthenticator,
                     'firewall_name' => $this->firewallName,
                     'redirect_route_name' => $this->redirectRouteName,
-                    'password_details' => new TemplateClassDetails($passwordHasher, $this->phpCompatUtil->canUseTypedProperties()),
+                    'password_class' => $generator->createClassHelper($passwordHasher),
                     'use_password_hasher' => UserPasswordHasherInterface::class === $passwordHasher,
                 ],
                 $userRepoVars

src/Resources/config/makers.xml

@@ -72,7 +72,6 @@
                 <argument type="service" id="maker.renderer.form_type_renderer" />
                 <argument type="service" id="router" />
                 <argument type="service" id="maker.doctrine_helper" />
-                <argument type="service" id="maker.php_compat_util" />
                 <tag name="maker.command" />
             </service>
 

src/Resources/skeleton/registration/RegistrationController.tpl.php

@@ -7,11 +7,11 @@
 class <?= $class_name; ?> extends <?= $parent_class_name; ?><?= "\n" ?>
 {
 <?php if ($will_verify_email): ?>
-<?= $email_verifier_details->getPropertyStatement() ?>
+<?= $email_verifier_class->getPropertyStatement() ?>
 
-    public function __construct(<?= $email_verifier_details->getMethodArgument() ?>)
+    public function __construct(<?= $email_verifier_class->getMethodArgument() ?>)
     {
-        <?= $email_verifier_details->getConstructorArgument(true, false) ?>
+        <?= $email_verifier_class->getConstructorArgument(true, false) ?>
     }
 
 <?php endif; ?>
@@ -22,7 +22,7 @@ public function __construct(<?= $email_verifier_details->getMethodArgument() ?>)
      * @Route("<?= $route_path ?>", name="<?= $route_name ?>")
      */
 <?php } ?>
-    public function register(Request $request, <?= $password_details->getMethodArgument() ?><?= $authenticator_full_class_name ? sprintf(', GuardAuthenticatorHandler $guardHandler, %s $authenticator', $authenticator_class_name) : '' ?>): Response
+    public function register(Request $request, <?= $password_class->getMethodArgument() ?><?= $authenticator_full_class_name ? sprintf(', GuardAuthenticatorHandler $guardHandler, %s $authenticator', $authenticator_class_name) : '' ?>): Response
     {
         $user = new <?= $user_class_name ?>();
         $form = $this->createForm(<?= $form_class_name ?>::class, $user);
@@ -32,9 +32,9 @@ public function register(Request $request, <?= $password_details->getMethodArgum
             // encode the plain password
             $user->set<?= ucfirst($password_field) ?>(
 <?php if ($use_password_hasher) : ?>
-                <?= $password_details->getVariable() ?>->hashPassword(
+                <?= $password_class->getVariable() ?>->hashPassword(
 <?php else: ?>
-                <?= $password_details->getVariable() ?>->encodePassword(
+                <?= $password_class->getVariable() ?>->encodePassword(
 <?php endif; ?>
                     $user,
                     $form->get('plainPassword')->getData()
@@ -47,7 +47,7 @@ public function register(Request $request, <?= $password_details->getMethodArgum
 <?php if ($will_verify_email): ?>
 
             // generate a signed url and email it to the user
-            <?= $email_verifier_details->getProperty() ?>->sendEmailConfirmation('app_verify_email', $user,
+            <?= $email_verifier_class->getProperty() ?>->sendEmailConfirmation('app_verify_email', $user,
                 (new TemplatedEmail())
                     ->from(new Address('<?= $from_email ?>', '<?= $from_email_name ?>'))
                     ->to($user-><?= $email_getter ?>())
@@ -108,7 +108,7 @@ public function verifyUserEmail(Request $request<?= $verify_email_anonymously ?
 
         // validate email confirmation link, sets User::isVerified=true and persists
         try {
-            <?= $email_verifier_details->getProperty() ?>->handleEmailConfirmation($request, <?= $verify_email_anonymously ? '$user' : '$this->getUser()' ?>);
+            <?= $email_verifier_class->getProperty() ?>->handleEmailConfirmation($request, <?= $verify_email_anonymously ? '$user' : '$this->getUser()' ?>);
         } catch (VerifyEmailExceptionInterface $exception) {
             $this->addFlash('verify_email_error', $exception->getReason());