feature #1223 Twig extension: create with a runtime class (94noni)

This PR was squashed before being merged into the 1.0-dev branch.

Discussion
----------

Twig extension: create with a runtime class

This PR introduce a way to generate a twig runtime linked to the twig extension via the `make:twig-extension` command

Fixes #1222

For now I did not touch the test, just want to gather early feedbacks :)

Commits
-------

dc640e2 Twig extension: create with a runtime class

Author: weaverryan

src/Maker/MakeTwigExtension.php

@@ -20,6 +20,7 @@
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Twig\Extension\AbstractExtension;
+use Twig\Extension\RuntimeExtensionInterface;
 use Twig\TwigFilter;
 use Twig\TwigFunction;
 
@@ -36,7 +37,7 @@ public static function getCommandName(): string
 
     public static function getCommandDescription(): string
     {
-        return 'Creates a new Twig extension class';
+        return 'Creates a new Twig extension with its runtime class';
     }
 
     public function configureCommand(Command $command, InputConfiguration $inputConfig): void
@@ -49,22 +50,41 @@ public function configureCommand(Command $command, InputConfiguration $inputConf
 
     public function generate(InputInterface $input, ConsoleStyle $io, Generator $generator): void
     {
+        $name = $input->getArgument('name');
+
         $extensionClassNameDetails = $generator->createClassNameDetails(
-            $input->getArgument('name'),
+            $name,
             'Twig\\Extension\\',
             'Extension'
         );
 
+        $runtimeClassNameDetails = $generator->createClassNameDetails(
+            $name,
+            'Twig\\Runtime\\',
+            'Runtime'
+        );
+
         $useStatements = new UseStatementGenerator([
             AbstractExtension::class,
             TwigFilter::class,
             TwigFunction::class,
+            $runtimeClassNameDetails->getFullName(),
+        ]);
+
+        $runtimeUseStatements = new UseStatementGenerator([
+            RuntimeExtensionInterface::class,
         ]);
 
         $generator->generateClass(
             $extensionClassNameDetails->getFullName(),
             'twig/Extension.tpl.php',
-            ['use_statements' => $useStatements]
+            ['use_statements' => $useStatements, 'runtime_class_name' => $runtimeClassNameDetails->getShortName()]
+        );
+
+        $generator->generateClass(
+            $runtimeClassNameDetails->getFullName(),
+            'twig/Runtime.tpl.php',
+            ['use_statements' => $runtimeUseStatements]
         );
 
         $generator->writeChanges();

src/Resources/help/MakeTwigExtension.txt

@@ -1,4 +1,4 @@
-The <info>%command.name%</info> command generates a new twig extension class.
+The <info>%command.name%</info> command generates a new twig extension with its runtime class.
 
 <info>php %command.full_name% AppExtension</info>
 

src/Resources/skeleton/twig/Extension.tpl.php

@@ -12,19 +12,14 @@ public function getFilters(): array
             // If your filter generates SAFE HTML, you should add a third
             // parameter: ['is_safe' => ['html']]
             // Reference: https://twig.symfony.com/doc/3.x/advanced.html#automatic-escaping
-            new TwigFilter('filter_name', [$this, 'doSomething']),
+            new TwigFilter('filter_name', [<?= $runtime_class_name ?>::class, 'doSomething']),
         ];
     }
 
     public function getFunctions(): array
     {
         return [
-            new TwigFunction('function_name', [$this, 'doSomething']),
+            new TwigFunction('function_name', [<?= $runtime_class_name ?>::class, 'doSomething']),
         ];
     }
-
-    public function doSomething($value)
-    {
-        // ...
-    }
 }

src/Resources/skeleton/twig/Runtime.tpl.php

@@ -0,0 +1,18 @@
+<?= "<?php\n" ?>
+
+namespace <?= $namespace; ?>;
+
+<?= $use_statements ?>
+
+class <?= $class_name ?> implements RuntimeExtensionInterface
+{
+    public function __construct()
+    {
+        // Inject dependencies if needed
+    }
+
+    public function doSomething($value)
+    {
+        // ...
+    }
+}