Fixing a troublesome test on Windows

Author: weaverryan

src/Test/MakerTestCase.php

@@ -54,6 +54,10 @@ protected function executeMakerCommand(MakerTestDetails $testDetails)
             $this->markTestSkipped();
         }
 
+        if ($testDetails->skipOnWindows() && '\\' === \DIRECTORY_SEPARATOR) {
+            $this->markTestSkipped('This test is not supported on Windows');
+        }
+
         $testEnv = MakerTestEnvironment::create($testDetails);
 
         // prepare environment to test

src/Test/MakerTestDetails.php

@@ -24,6 +24,7 @@ final class MakerTestDetails
     private array $requiredPackageVersions = [];
     private int $blockedPhpVersionUpper = 0;
     private int $blockedPhpVersionLower = 0;
+    private bool $skipOnWindows = false;
 
     public function __construct(
         private MakerInterface $maker,
@@ -175,4 +176,11 @@ public function getPreRunCallbacks(): array
     {
         return $this->preRunCallbacks;
     }
+
+    public function skipOnWindows(): self
+    {
+        $this->skipOnWindows = true;
+
+        return $this;
+    }
 }

tests/Maker/TemplateLinterTest.php

@@ -34,6 +34,8 @@ public function getTestDetails(): \Generator
     {
         yield 'lints_templates_with_custom_php_cs_fixer_and_config' => [$this->createMakerTest()
             ->addExtraDependencies('friendsofphp/php-cs-fixer')
+            // these tests are troublesome on Windows
+            ->skipOnWindows()
             ->run(function (MakerTestRunner $runner) {
                 $runner->copy('template-linter/php-cs-fixer.test.php', 'php-cs-fixer.test.php');
 
@@ -60,6 +62,8 @@ public function getTestDetails(): \Generator
 
         yield 'lints_templates_with_flex_generated_config_file' => [$this->createMakerTest()
             ->addExtraDependencies('friendsofphp/php-cs-fixer')
+            // these tests are troublesome on Windows
+            ->skipOnWindows()
             ->run(function (MakerTestRunner $runner) {
                 $runner->replaceInFile(
                     '.php-cs-fixer.dist.php',