Skip to content

Commit bb224fb

Browse files
committed
minor #932 [make:migration] remove legacy dependency in tests (jrushlow)
This PR was merged into the 1.0-dev branch. Discussion ---------- [make:migration] remove legacy dependency in tests Removes legacy code thats not needed anymore. Commits ------- 9128cb5 [ci] remove legacy dependency
2 parents 09c8625 + 9128cb5 commit bb224fb

File tree

1 file changed

+0
-24
lines changed

1 file changed

+0
-24
lines changed

tests/Maker/MakeMigrationTest.php

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,6 @@ public function getTestDetails()
2929
// only requires doctrine/dbal. But we're testing with the ORM,
3030
// so let's install it
3131
->addExtraDependencies('doctrine/orm:@stable')
32-
/*
33-
* @legacy doctrine/migrations does not support psr/log >=2
34-
* some symfony components use psr/log ^1 || ^2 || ^3
35-
* once doctrine/migrations supports psr log >= 2, this line can be removed.
36-
*/
37-
->addExtraDependencies('psr/log:^1.1.4')
3832
->assert(function (string $output, string $directory) {
3933
$this->assertStringContainsString('Success', $output);
4034

@@ -60,12 +54,6 @@ public function getTestDetails()
6054
// sync the database, so no changes are needed
6155
->configureDatabase()
6256
->addExtraDependencies('doctrine/orm:@stable')
63-
/*
64-
* @legacy doctrine/migrations does not support psr/log >=2
65-
* some symfony components use psr/log ^1 || ^2 || ^3
66-
* once doctrine/migrations supports psr log >= 2, this line can be removed.
67-
*/
68-
->addExtraDependencies('psr/log:^1.1.4')
6957
->assert(function (string $output, string $directory) {
7058
$this->assertStringNotContainsString('Success', $output);
7159

@@ -83,12 +71,6 @@ public function getTestDetails()
8371
->configureDatabase(false)
8472
->addRequiredPackageVersion('doctrine/doctrine-migrations-bundle', '>=3')
8573
->addExtraDependencies('doctrine/orm:@stable')
86-
/*
87-
* @legacy doctrine/migrations does not support psr/log >=2
88-
* some symfony components use psr/log ^1 || ^2 || ^3
89-
* once doctrine/migrations supports psr log >= 2, this line can be removed.
90-
*/
91-
->addExtraDependencies('psr/log:^1.1.4')
9274
// generate a migration first
9375
->addPreMakeCommand('php bin/console make:migration')
9476
->assert(function (string $output, string $directory) {
@@ -108,12 +90,6 @@ public function getTestDetails()
10890
->configureDatabase(false)
10991
->addRequiredPackageVersion('doctrine/doctrine-migrations-bundle', '>=3')
11092
->addExtraDependencies('doctrine/orm:@stable')
111-
/*
112-
* @legacy doctrine/migrations does not support psr/log >=2
113-
* some symfony components use psr/log ^1 || ^2 || ^3
114-
* once doctrine/migrations supports psr log >= 2, this line can be removed.
115-
*/
116-
->addExtraDependencies('psr/log:^1.1.4')
11793
// generate a migration first
11894
->addPreMakeCommand('php bin/console make:migration')
11995
->assert(function (string $output, string $directory) {

0 commit comments

Comments
 (0)