minor #48 Minor code improvements (javiereguiluz)

This PR was merged into the 1.0-dev branch.

Discussion
----------

Minor code improvements

Spotted with PHP-CS-Fixer and Php Inspections (EA Extended).

Commits
-------

51af48d Minor code improvements

Author: fabpot

src/Command/AbstractCommand.php

@@ -98,7 +98,7 @@ protected function interact(InputInterface $input, OutputInterface $output)
                 continue;
             }
 
-            if (in_array($argument->getName(), $this->nonInteractiveArguments)) {
+            if (in_array($argument->getName(), $this->nonInteractiveArguments, true)) {
                 continue;
             }
 

src/DependencyBuilder.php

@@ -13,7 +13,7 @@ final class DependencyBuilder
      * the user if other required dependencies are missing. An example
      * is the "validator" when trying to work with forms.
      */
-    public function addClassDependency(string $class, string $package, bool $required = true)
+    public function addClassDependency(string $class, string $package, bool $required = true): void
     {
         $this->dependencies[$class] = [
             'name' => $package,

src/FileManager.php

@@ -60,7 +60,7 @@ public function fileExists($path): bool
 
     private function absolutizePath($path): string
     {
-        if ('/' === substr($path, 0, 1)) {
+        if (0 === strpos($path, '/')) {
             return $path;
         }
 

src/Generator.php

@@ -28,7 +28,7 @@ public function __construct(FileManager $fileManager)
         $this->fileManager = $fileManager;
     }
 
-    public function setIO(SymfonyStyle $io)
+    public function setIO(SymfonyStyle $io): void
     {
         $this->io = $io;
         $this->fileManager->setIO($io);

src/Resources/skeleton/form/Type.php.txt

@@ -18,9 +18,9 @@ class {{ form_class_name }} extends AbstractType
 
     public function configureOptions(OptionsResolver $resolver)
     {
-        $resolver->setDefaults(array(
+        $resolver->setDefaults([
             // uncomment if you want to bind to a class
             //'data_class' => {{ entity_class_name }}::class,
-        ));
+        ]);
     }
 }

src/Str.php

@@ -120,10 +120,6 @@ public static function getRandomTerm(): string
             'kangaroo',
         ];
 
-        return sprintf(
-            '%s %s',
-            $adjectives[array_rand($adjectives)],
-            $nouns[array_rand($nouns)]
-        );
+        return sprintf('%s %s', $adjectives[array_rand($adjectives)], $nouns[array_rand($nouns)]);
     }
 }

tests/Command/FunctionalTest.php

@@ -30,7 +30,7 @@ class FunctionalTest extends TestCase
 
     public function setUp()
     {
-        $tmpDir = sys_get_temp_dir().'/sf'.mt_rand(111111, 999999);
+        $tmpDir = sys_get_temp_dir().'/sf'.random_int(111111, 999999);
         @mkdir($tmpDir, 0777, true);
 
         $this->targetDir = $tmpDir;
@@ -53,7 +53,7 @@ public function testCommands(AbstractCommand $command, array $inputs)
 
         $tester = new CommandTester($command);
         $tester->setInputs($inputs);
-        $tester->execute(array());
+        $tester->execute([]);
 
         $this->assertContains('Success', $tester->getDisplay());
 
@@ -199,7 +199,7 @@ private function parsePHPFiles($output)
                 continue;
             }
 
-            list(, $filename) = explode(':', $line);
+            [, $filename] = explode(':', $line);
             $files[] = trim($filename);
         }
 

tests/StrTest.php

@@ -100,4 +100,3 @@ public function provideAsTwigVariable()
         yield ['generate', 'generate'];
     }
 }
-