Skip to content

Commit f003e99

Browse files
committed
minor #1063 [ci] fix symfony serializer deps in ci (jrushlow)
This PR was merged into the 1.0-dev branch. Discussion ---------- [ci] fix symfony serializer deps in ci When running serializer tests in Symfony <= 5.3, composer attempts to use `symfony/[email protected]` (The latest version at the time of this PR) which conflicts with `symfony/property-info` `<5.4`. This in turn causes our tests to fail due to an uninstallable set of packages. As a work around, until something better comes along, adding `symfony/serializer-pack:*` as an extra test dependency allows lesser version of `serializer-pack` to be used in the test without conflict with its underlying packages. Commits ------- 976a52b [ci] install serializer pack w/o conflicts in symfony <= 5.3
2 parents 4ca9b7d + 976a52b commit f003e99

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

tests/Maker/MakeSerializerEncoderTest.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,11 @@ protected function getMakerClass(): string
2525
public function getTestDetails()
2626
{
2727
yield 'it_makes_serializer_encoder' => [$this->createMakerTest()
28+
// serializer-pack 1.1 requires symfony/property-info >= 5.4
29+
// adding symfony/serializer-pack:* as an extra depends allows
30+
// us to use serializer-pack < 1.1 which does not conflict with
31+
// property-info < 5.4. E.g. Symfony 5.3 tests. See PR 1063
32+
->addExtraDependencies('symfony/serializer-pack:*')
2833
->run(function (MakerTestRunner $runner) {
2934
$runner->runMaker(
3035
[

tests/Maker/MakeSerializerNormalizerTest.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,11 @@ protected function getMakerClass(): string
2525
public function getTestDetails()
2626
{
2727
yield 'it_makes_serializer_normalizer' => [$this->createMakerTest()
28+
// serializer-pack 1.1 requires symfony/property-info >= 5.4
29+
// adding symfony/serializer-pack:* as an extra depends allows
30+
// us to use serializer-pack < 1.1 which does not conflict with
31+
// property-info < 5.4. E.g. Symfony 5.3 tests. See PR 1063
32+
->addExtraDependencies('symfony/serializer-pack:*')
2833
->run(function (MakerTestRunner $runner) {
2934
$runner->runMaker(
3035
[

0 commit comments

Comments
 (0)