Skip to content

[make:voter] Set type for subject in Voter template #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2022
Merged

[make:voter] Set type for subject in Voter template #1221

merged 1 commit into from
Nov 8, 2022

Conversation

N-M
Copy link
Contributor

@N-M N-M commented Oct 10, 2022 •
edited
Loading

Setting type for $subject in Voter template so phpstan issue can be covered by default

 ------ ----------------------------------------------------------------- 
  15     Method App\Security\Voter\TenantVoter::supports() has parameter  
         $subject with no type specified.                                 
 ------ -----------------------------------------------------------------

@N-M
Set subject for subject in Voter template
19e181d 
Setting type for $subject in Voter template.
@N-M N-M changed the title Set subject for subject in Voter template Set type for subject in Voter template Oct 14, 2022
@weaverryan weaverryan added the Status: Reviewed Has been reviewed by a maintainer label Oct 19, 2022
@jrushlow jrushlow added the Feature New Feature label Nov 8, 2022
@jrushlow jrushlow changed the title Set type for subject in Voter template [make:voter] Set type for subject in Voter template Nov 8, 2022
jrushlow
jrushlow approved these changes Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @N-M!

@jrushlow jrushlow merged commit e9ad359 into symfony:main Nov 8, 2022
@jrushlow jrushlow mentioned this pull request Nov 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weaverryan weaverryan weaverryan approved these changes

@94noni 94noni 94noni approved these changes

@jrushlow jrushlow jrushlow approved these changes

Assignees
No one assigned
Labels
Feature New Feature Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@N-M @weaverryan @94noni @jrushlow