Leverage str_contains/str_starts_with

Signed-off-by: Alexander M. Turek <[email protected]>

Author: derrabus

Command/ConsumeMessagesCommand.php

@@ -142,7 +142,7 @@ protected function interact(InputInterface $input, OutputInterface $output)
      */
     protected function execute(InputInterface $input, OutputInterface $output)
     {
-        if (false !== strpos($input->getFirstArgument(), ':consume-')) {
+        if (str_contains($input->getFirstArgument(), ':consume-')) {
             $message = 'The use of the "messenger:consume-messages" command is deprecated since version 4.3 and will be removed in 5.0. Use "messenger:consume" instead.';
             @trigger_error($message, \E_USER_DEPRECATED);
             $output->writeln(sprintf('<comment>%s</comment>', $message));
@@ -209,9 +209,9 @@ private function convertToBytes(string $memoryLimit): int
     {
         $memoryLimit = strtolower($memoryLimit);
         $max = ltrim($memoryLimit, '+');
-        if (0 === strpos($max, '0x')) {
+        if (str_starts_with($max, '0x')) {
             $max = \intval($max, 16);
-        } elseif (0 === strpos($max, '0')) {
+        } elseif (str_starts_with($max, '0')) {
             $max = \intval($max, 8);
         } else {
             $max = (int) $max;

Handler/HandlerDescriptor.php

@@ -65,7 +65,7 @@ private function callableName(callable $handler): string
 
         if ($handler instanceof \Closure) {
             $r = new \ReflectionFunction($handler);
-            if (false !== strpos($r->name, '{closure}')) {
+            if (str_contains($r->name, '{closure}')) {
                 return 'Closure';
             }
             if ($class = $r->getClosureScopeClass()) {

Tests/Transport/AmqpExt/AmqpExtIntegrationTest.php

@@ -210,7 +210,7 @@ private function waitForOutput(Process $process, string $output, $timeoutInSecon
         $timedOutTime = time() + $timeoutInSeconds;
 
         while (time() < $timedOutTime) {
-            if (0 === strpos($process->getOutput(), $output)) {
+            if (str_starts_with($process->getOutput(), $output)) {
                 return;
             }
 

Tests/Transport/RedisExt/ConnectionTest.php

@@ -28,7 +28,7 @@ public static function setUpBeforeClass(): void
             $redis = Connection::fromDsn('redis://localhost/queue');
             $redis->get();
         } catch (TransportException $e) {
-            if (0 === strpos($e->getMessage(), 'ERR unknown command \'X')) {
+            if (str_starts_with($e->getMessage(), 'ERR unknown command \'X')) {
                 throw new SkippedTestSuiteError('Redis server >= 5 is required');
             }
 

TraceableMessageBus.php

@@ -86,7 +86,7 @@ private function getCaller(): array
                 $line = $trace[$i]['line'];
 
                 while (++$i < 8) {
-                    if (isset($trace[$i]['function'], $trace[$i]['file']) && empty($trace[$i]['class']) && 0 !== strpos($trace[$i]['function'], 'call_user_func')) {
+                    if (isset($trace[$i]['function'], $trace[$i]['file']) && empty($trace[$i]['class']) && !str_starts_with($trace[$i]['function'], 'call_user_func')) {
                         $file = $trace[$i]['file'];
                         $line = $trace[$i]['line'];
 

Transport/AmqpExt/AmqpTransportFactory.php

@@ -29,6 +29,6 @@ public function createTransport(string $dsn, array $options, SerializerInterface
 
     public function supports(string $dsn, array $options): bool
     {
-        return 0 === strpos($dsn, 'amqp://');
+        return str_starts_with($dsn, 'amqp://');
     }
 }

Transport/Doctrine/DoctrineTransportFactory.php

@@ -52,6 +52,6 @@ public function createTransport(string $dsn, array $options, SerializerInterface
 
     public function supports(string $dsn, array $options): bool
     {
-        return 0 === strpos($dsn, 'doctrine://');
+        return str_starts_with($dsn, 'doctrine://');
     }
 }

Transport/InMemoryTransportFactory.php

@@ -31,7 +31,7 @@ public function createTransport(string $dsn, array $options, SerializerInterface
 
     public function supports(string $dsn, array $options): bool
     {
-        return 0 === strpos($dsn, 'in-memory://');
+        return str_starts_with($dsn, 'in-memory://');
     }
 
     public function reset()

Transport/RedisExt/RedisTransportFactory.php

@@ -30,6 +30,6 @@ public function createTransport(string $dsn, array $options, SerializerInterface
 
     public function supports(string $dsn, array $options): bool
     {
-        return 0 === strpos($dsn, 'redis://');
+        return str_starts_with($dsn, 'redis://');
     }
 }

Transport/Serialization/PhpSerializer.php

@@ -29,7 +29,7 @@ public function decode(array $encodedEnvelope): Envelope
             throw new MessageDecodingFailedException('Encoded envelope should have at least a "body".');
         }
 
-        if (false === strpos($encodedEnvelope['body'], '}', -1)) {
+        if (!str_contains($encodedEnvelope['body'], '}', -1)) {
             $encodedEnvelope['body'] = base64_decode($encodedEnvelope['body']);
         }
 

Transport/Serialization/Serializer.php

@@ -111,7 +111,7 @@ private function decodeStamps(array $encodedEnvelope): array
     {
         $stamps = [];
         foreach ($encodedEnvelope['headers'] as $name => $value) {
-            if (0 !== strpos($name, self::STAMP_HEADER_PREFIX)) {
+            if (!str_starts_with($name, self::STAMP_HEADER_PREFIX)) {
                 continue;
             }
 

Transport/Sync/SyncTransportFactory.php

@@ -35,6 +35,6 @@ public function createTransport(string $dsn, array $options, SerializerInterface
 
     public function supports(string $dsn, array $options): bool
     {
-        return 0 === strpos($dsn, 'sync://');
+        return str_starts_with($dsn, 'sync://');
     }
 }