Making the serializer configurable by transport

Author: weaverryan

CHANGELOG.md

@@ -4,10 +4,12 @@ CHANGELOG
 4.3.0
 -----
 
+ * [BC BREAK] The `TransportFactoryInterface::createTransport()` signature
+   changed: a required 3rd `SerializerInterface` argument was added.
  * Added a new `SyncTransport` along with `ForceCallHandlersStamp` to
    explicitly handle messages synchronously.
  * Added optional parameter `prefetch_count` in connection configuration, 
-   to setup channel prefetch count
+   to setup channel prefetch count.
  * New classes: `RoutableMessageBus`, `AddBusNameStampMiddleware`
    and `BusNameStamp` were added, which allow you to add a bus identifier
    to the `Envelope` then find the correct bus when receiving from

Tests/Transport/AmqpExt/AmqpTransportFactoryTest.php

@@ -21,9 +21,7 @@ class AmqpTransportFactoryTest extends TestCase
 {
     public function testSupportsOnlyAmqpTransports()
     {
-        $factory = new AmqpTransportFactory(
-            $this->getMockBuilder(SerializerInterface::class)->getMock()
-        );
+        $factory = new AmqpTransportFactory();
 
         $this->assertTrue($factory->supports('amqp://localhost', []));
         $this->assertFalse($factory->supports('sqs://localhost', []));
@@ -32,12 +30,11 @@ public function testSupportsOnlyAmqpTransports()
 
     public function testItCreatesTheTransport()
     {
-        $factory = new AmqpTransportFactory(
-            $serializer = $this->getMockBuilder(SerializerInterface::class)->getMock()
-        );
+        $factory = new AmqpTransportFactory();
+        $serializer = $this->createMock(SerializerInterface::class);
 
         $expectedTransport = new AmqpTransport(Connection::fromDsn('amqp://localhost', ['foo' => 'bar']), $serializer);
 
-        $this->assertEquals($expectedTransport, $factory->createTransport('amqp://localhost', ['foo' => 'bar']));
+        $this->assertEquals($expectedTransport, $factory->createTransport('amqp://localhost', ['foo' => 'bar'], $serializer));
     }
 }

Transport/AmqpExt/AmqpTransportFactory.php

@@ -11,7 +11,6 @@
 
 namespace Symfony\Component\Messenger\Transport\AmqpExt;
 
-use Symfony\Component\Messenger\Transport\Serialization\PhpSerializer;
 use Symfony\Component\Messenger\Transport\Serialization\SerializerInterface;
 use Symfony\Component\Messenger\Transport\TransportFactoryInterface;
 use Symfony\Component\Messenger\Transport\TransportInterface;
@@ -23,16 +22,9 @@
  */
 class AmqpTransportFactory implements TransportFactoryInterface
 {
-    private $serializer;
-
-    public function __construct(SerializerInterface $serializer = null)
-    {
-        $this->serializer = $serializer ?? new PhpSerializer();
-    }
-
-    public function createTransport(string $dsn, array $options): TransportInterface
+    public function createTransport(string $dsn, array $options, SerializerInterface $serializer): TransportInterface
     {
-        return new AmqpTransport(Connection::fromDsn($dsn, $options), $this->serializer);
+        return new AmqpTransport(Connection::fromDsn($dsn, $options), $serializer);
     }
 
     public function supports(string $dsn, array $options): bool

Transport/TransportFactory.php

@@ -12,6 +12,7 @@
 namespace Symfony\Component\Messenger\Transport;
 
 use Symfony\Component\Messenger\Exception\InvalidArgumentException;
+use Symfony\Component\Messenger\Transport\Serialization\SerializerInterface;
 
 /**
  * @author Samuel Roze <[email protected]>
@@ -30,11 +31,11 @@ public function __construct(iterable $factories)
         $this->factories = $factories;
     }
 
-    public function createTransport(string $dsn, array $options): TransportInterface
+    public function createTransport(string $dsn, array $options, SerializerInterface $serializer): TransportInterface
     {
         foreach ($this->factories as $factory) {
             if ($factory->supports($dsn, $options)) {
-                return $factory->createTransport($dsn, $options);
+                return $factory->createTransport($dsn, $options, $serializer);
             }
         }
 

Transport/TransportFactoryInterface.php

@@ -11,6 +11,8 @@
 
 namespace Symfony\Component\Messenger\Transport;
 
+use Symfony\Component\Messenger\Transport\Serialization\SerializerInterface;
+
 /**
  * Creates a Messenger transport.
  *
@@ -20,7 +22,7 @@
  */
 interface TransportFactoryInterface
 {
-    public function createTransport(string $dsn, array $options): TransportInterface;
+    public function createTransport(string $dsn, array $options, SerializerInterface $serializer): TransportInterface;
 
     public function supports(string $dsn, array $options): bool;
 }