[PHP8] add type hints

Author: nicolas-grekas

Php80.php

@@ -19,15 +19,12 @@
  */
 final class Php80
 {
-    public static function fdiv($dividend, $divisor)
+    public static function fdiv(float $dividend, float $divisor): float
     {
-        $dividend = self::floatArg($dividend, __FUNCTION__, 1);
-        $divisor = self::floatArg($divisor, __FUNCTION__, 2);
-
-        return (float) @($dividend / $divisor);
+        return @($dividend / $divisor);
     }
 
-    public static function preg_last_error_msg()
+    public static function preg_last_error_msg(): string
     {
         switch (preg_last_error()) {
             case PREG_INTERNAL_ERROR:
@@ -48,17 +45,4 @@ public static function preg_last_error_msg()
                 return 'Unknown error';
         }
     }
-
-    private static function floatArg($value, $caller, $pos)
-    {
-        if (\is_float($value)) {
-            return $value;
-        }
-
-        if (!\is_numeric($value)) {
-            throw new \TypeError(sprintf('%s() expects parameter %d to be float, %s given', $caller, $pos, \gettype($value)));
-        }
-
-        return (float) $value;
-    }
 }

bootstrap.php

@@ -11,9 +11,9 @@
 
 use Symfony\Polyfill\Php80 as p;
 
-if (PHP_VERSION_ID < 80000 && PHP_VERSION_ID >= 70000) {
+if (PHP_VERSION_ID < 80000) {
     if (!function_exists('fdiv')) {
-        function fdiv($dividend, $divisor) { return p\Php80::fdiv($dividend, $divisor); }
+        function fdiv(float $dividend, float $divisor): float { return p\Php80::fdiv($dividend, $divisor); }
     }
 
     if (!function_exists('preg_last_error_msg')) {