fixed pr comments

Author: rbaarsma

Tests/Factory/AbstractHttpMessageFactoryTest.php

@@ -37,7 +37,7 @@ public function setUp(): void
         $this->tmpDir = sys_get_temp_dir();
     }
 
-    public function testCreateRequest(): void
+    public function testCreateRequest()
     {
         $stdClass = new \stdClass();
         $request = new Request(
@@ -116,7 +116,7 @@ public function testCreateRequest(): void
         $this->assertEquals(['2.8'], $psrRequest->getHeader('X-Symfony'));
     }
 
-    public function testGetContentCanBeCalledAfterRequestCreation(): void
+    public function testGetContentCanBeCalledAfterRequestCreation()
     {
         $header = ['HTTP_HOST' => 'dunglas.fr'];
         $request = new Request([], [], [], [], [], $header, 'Content');
@@ -140,7 +140,7 @@ private function createUploadedFile($content, $originalName, $mimeType, $error)
         return new UploadedFile($path, $originalName, $mimeType, filesize($path), $error, true);
     }
 
-    public function testCreateResponse(): void
+    public function testCreateResponse()
     {
         $response = new Response(
             'Response content.',
@@ -160,7 +160,7 @@ public function testCreateResponse(): void
         $this->assertRegExp('{city=Lille; expires=Wed, 13-Jan-2021 22:23:01 GMT;( max-age=\d+;)? path=/; httponly}i', $cookieHeader[0]);
     }
 
-    public function testCreateResponseFromStreamed(): void
+    public function testCreateResponseFromStreamed()
     {
         $response = new StreamedResponse(function () {
             echo "Line 1\n";
@@ -175,7 +175,7 @@ public function testCreateResponseFromStreamed(): void
         $this->assertEquals("Line 1\nLine 2\n", $psrResponse->getBody()->__toString());
     }
 
-    public function testCreateResponseFromBinaryFile(): void
+    public function testCreateResponseFromBinaryFile()
     {
         $path = tempnam($this->tmpDir, uniqid());
         file_put_contents($path, 'Binary');
@@ -187,7 +187,7 @@ public function testCreateResponseFromBinaryFile(): void
         $this->assertEquals('Binary', $psrResponse->getBody()->__toString());
     }
 
-    public function testUploadErrNoFile(): void
+    public function testUploadErrNoFile()
     {
         if (class_exists('Symfony\Component\HttpFoundation\HeaderUtils')) {
             // Symfony 4.1+

Tests/Factory/HttpFoundationFactoryTest.php

@@ -21,6 +21,7 @@
 use Symfony\Bridge\PsrHttpMessage\Tests\Fixtures\Uri;
 use Symfony\Component\HttpFoundation\Cookie;
 use Symfony\Component\HttpFoundation\File\Exception\FileException;
+use Symfony\Component\HttpFoundation\File\UploadedFile as HttpFoundationUploadedFile;
 
 /**
  * @author Kévin Dunglas <[email protected]>
@@ -39,7 +40,7 @@ public function setUp(): void
         $this->tmpDir = sys_get_temp_dir();
     }
 
-    public function testCreateRequest(): void
+    public function testCreateRequest()
     {
         $stdClass = new \stdClass();
         $serverRequest = new ServerRequest(
@@ -84,7 +85,7 @@ public function testCreateRequest(): void
         $this->assertEquals(['a', 'b'], $symfonyRequest->headers->all('X-data'));
     }
 
-    public function testCreateRequestWithNullParsedBody(): void
+    public function testCreateRequestWithNullParsedBody()
     {
         $serverRequest = new ServerRequest(
             '1.1',
@@ -104,7 +105,7 @@ public function testCreateRequestWithNullParsedBody(): void
         $this->assertCount(0, $this->factory->createRequest($serverRequest)->request);
     }
 
-    public function testCreateRequestWithObjectParsedBody(): void
+    public function testCreateRequestWithObjectParsedBody()
     {
         $serverRequest = new ServerRequest(
             '1.1',
@@ -124,7 +125,7 @@ public function testCreateRequestWithObjectParsedBody(): void
         $this->assertCount(0, $this->factory->createRequest($serverRequest)->request);
     }
 
-    public function testCreateRequestWithUri(): void
+    public function testCreateRequestWithUri()
     {
         $serverRequest = new ServerRequest(
             '1.1',
@@ -144,7 +145,7 @@ public function testCreateRequestWithUri(): void
         $this->assertEquals('/about/kevin', $this->factory->createRequest($serverRequest)->getPathInfo());
     }
 
-    public function testCreateUploadedFile(): void
+    public function testCreateUploadedFile()
     {
         $uploadedFile = $this->createUploadedFile('An uploaded file.', UPLOAD_ERR_OK, 'myfile.txt', 'text/plain');
         $symfonyUploadedFile = $this->callCreateUploadedFile($uploadedFile);
@@ -161,7 +162,7 @@ public function testCreateUploadedFile(): void
         $this->assertEquals('An uploaded file.', file_get_contents($this->tmpDir.'/'.$uniqid));
     }
 
-    public function testCreateUploadedFileWithError(): void
+    public function testCreateUploadedFileWithError()
     {
         $this->expectException(FileException::class);
         $this->expectExceptionMessage('The file "e" could not be written on disk.');
@@ -182,7 +183,7 @@ private function createUploadedFile($content, $error, $clientFileName, $clientMe
         return new UploadedFile($filePath, filesize($filePath), $error, $clientFileName, $clientMediaType);
     }
 
-    private function callCreateUploadedFile(UploadedFileInterface $uploadedFile): \Symfony\Component\HttpFoundation\File\UploadedFile
+    private function callCreateUploadedFile(UploadedFileInterface $uploadedFile): HttpFoundationUploadedFile
     {
         $reflection = new \ReflectionClass($this->factory);
         $createUploadedFile = $reflection->getMethod('createUploadedFile');
@@ -191,7 +192,7 @@ private function callCreateUploadedFile(UploadedFileInterface $uploadedFile): \S
         return $createUploadedFile->invokeArgs($this->factory, [$uploadedFile]);
     }
 
-    public function testCreateResponse(): void
+    public function testCreateResponse()
     {
         $response = new Response(
             '1.0',